Skip to content

alpaka split job#72

Merged
fbzli merged 4 commits into
feature/v2from
feature/alpaka-split-job
Jun 9, 2026
Merged

alpaka split job#72
fbzli merged 4 commits into
feature/v2from
feature/alpaka-split-job

Conversation

@fbzli

@fbzli fbzli commented May 14, 2026

Copy link
Copy Markdown
Contributor

Depends on #71

@fbzli fbzli requested a review from Copilot May 14, 2026 14:33
@fbzli fbzli added the v2 The next generation action label May 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Splits the Alpaka build+upload workflow into separate jobs and introduces consistent working-directory handling and artifact stashing/unstashing so upload can run using build outputs from a prior job.

Changes:

  • Added working-directory input/defaults and updated artifact stash/unstash paths to support Gradle projects not located at repo root.
  • Refactored Alpaka workflow into build (assemble + stash outputs) and upload (restore outputs + publish) jobs.
  • Adjusted concurrency/job naming and artifact retention/compression settings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/android_build_store_upload.yml Adds working-directory support and stashes/unstashes the AAB between build and Play Store upload jobs.
.github/workflows/android_build_alpaka_upload.yml Splits Alpaka pipeline into build/upload jobs and transfers build outputs via artifacts for the publish step.
Comments suppressed due to low confidence (2)

.github/workflows/android_build_alpaka_upload.yml:218

  • Same path concatenation issue here: downloading into ${{ inputs.working-directory }}${{ needs.build.outputs.app_module_path }}/... relies on inputs.working-directory ending with /. Prefer explicit path joining to accept both android and android/ inputs reliably.
      - name: Unstash build output
        uses: actions/download-artifact@v4
        with:
          name: ${{ inputs.flavor }}_app_outputs
          path: ${{ inputs.working-directory }}${{ needs.build.outputs.app_module_path }}/build/outputs/

.github/workflows/android_build_store_upload.yml:172

  • This download-artifact path has the same concatenation fragility as the upload step: it depends on inputs.working-directory ending with /. Prefer explicit path joining to avoid subtle path errors for callers.
      - name: Unstash app bundle
        uses: actions/download-artifact@v4
        with:
          name: app-bundle
          path: ${{ inputs.working-directory }}${{ env.AAB_STAGING_DIR }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/android_build_alpaka_upload.yml
Comment thread .github/workflows/android_build_alpaka_upload.yml
Comment thread .github/workflows/android_build_alpaka_upload.yml
Comment thread .github/workflows/android_build_alpaka_upload.yml
Comment thread .github/workflows/android_build_store_upload.yml
Comment thread .github/workflows/android_build_store_upload.yml
Base automatically changed from feature/maven-proxy-n-cache to feature/v2 June 9, 2026 07:41
@fbzli fbzli merged commit 7f4a0fa into feature/v2 Jun 9, 2026
4 checks passed
@fbzli fbzli deleted the feature/alpaka-split-job branch June 9, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 The next generation action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants