alpaka split job#72
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Splits the Alpaka build+upload workflow into separate jobs and introduces consistent working-directory handling and artifact stashing/unstashing so upload can run using build outputs from a prior job.
Changes:
- Added
working-directoryinput/defaults and updated artifact stash/unstash paths to support Gradle projects not located at repo root. - Refactored Alpaka workflow into
build(assemble + stash outputs) andupload(restore outputs + publish) jobs. - Adjusted concurrency/job naming and artifact retention/compression settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/android_build_store_upload.yml | Adds working-directory support and stashes/unstashes the AAB between build and Play Store upload jobs. |
| .github/workflows/android_build_alpaka_upload.yml | Splits Alpaka pipeline into build/upload jobs and transfers build outputs via artifacts for the publish step. |
Comments suppressed due to low confidence (2)
.github/workflows/android_build_alpaka_upload.yml:218
- Same path concatenation issue here: downloading into
${{ inputs.working-directory }}${{ needs.build.outputs.app_module_path }}/...relies oninputs.working-directoryending with/. Prefer explicit path joining to accept bothandroidandandroid/inputs reliably.
- name: Unstash build output
uses: actions/download-artifact@v4
with:
name: ${{ inputs.flavor }}_app_outputs
path: ${{ inputs.working-directory }}${{ needs.build.outputs.app_module_path }}/build/outputs/
.github/workflows/android_build_store_upload.yml:172
- This download-artifact path has the same concatenation fragility as the upload step: it depends on
inputs.working-directoryending with/. Prefer explicit path joining to avoid subtle path errors for callers.
- name: Unstash app bundle
uses: actions/download-artifact@v4
with:
name: app-bundle
path: ${{ inputs.working-directory }}${{ env.AAB_STAGING_DIR }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
M-Wong
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #71