split shared action code#69
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors Android CI workflows by extracting common setup logic into reusable composite actions under .github/actions, reducing duplication across workflows.
Changes:
- Replaced repeated checkout/JDK/zstd/Rust setup steps in multiple workflows with
android-base-setupandandroid-app-setupcomposite actions. - Added
ssh-setupcomposite action and migrated Alpaka workflow SSH preparation to it. - Split Play Store workflow into separate
buildandpublishjobs with artifact handoff.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/android_library_artifactory.yml | Uses android-base-setup and adds an input to optionally set up Rust. |
| .github/workflows/android_gradle_task.yml | Uses android-base-setup and allows optional PAT for checkout. |
| .github/workflows/android_code_quality.yml | Uses android-app-setup and centralizes Gradle properties setup. |
| .github/workflows/android_build_store_upload.yml | Uses android-app-setup, stages AAB as an artifact, adds a publish job. |
| .github/workflows/android_build_alpaka_upload.yml | Uses android-app-setup and replaces inline SSH logic with ssh-setup. |
| .github/actions/ssh-setup/action.yml | New composite action encapsulating SSH key + known_hosts setup. |
| .github/actions/android-base-setup/action.yml | New composite action for shared Android CI base environment setup. |
| .github/actions/android-app-setup/action.yml | New composite action building on base setup and exporting app/flavor/build outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbzli
force-pushed
the
feature/composite-actions
branch
from
2ea40b4 to
da611f3
Compare
fbzli
force-pushed
the
feature/composite-actions
branch
from
da611f3 to
1a6a5d8
Compare
fbzli
force-pushed
the
feature/composite-actions
branch
3 times, most recently
from
66f2f4b to
499caa1
Compare
fbzli
force-pushed
the
feature/composite-actions
branch
from
499caa1 to
65e4d69
Compare
| shell: bash | ||
| run: sudo apt-get install -y zstd | ||
|
|
||
| - name: Setup Rust toolchain |
There was a problem hiding this comment.
Würds Sinn machen das Prebuild Script als Teil von dieser Action zu haben?
There was a problem hiding this comment.
Ja. Und ich habe mir überlegt, das Script nicht als Input zu übergeben, sondern ein fixes File im Client-Repo unter .github/scripts/prebuild.sh oder so zu haben, das ausgeführt wird, wenn's existiert. Evtl ginge auch eine Composite Action, aber das macht Probleme wenn sie nicht existiert, bzw. kann nicht optional sein, soviel ich weiss.
There was a problem hiding this comment.
Bin nicht so Fan davon wenn die Action auf ein hardcodiertes Pre-Build Script versucht zu gehen. Lieber das Script als File-Pfad als Input nehmen (statt wie jetzt den effektiven Script Code als Input)
No description provided.