Add Zbs single-bit operations implementation (RV32, SystemVerilog)#191
Open
Add Zbs single-bit operations implementation (RV32, SystemVerilog)#191
Conversation
🔧 DE1-SoC Synthesis Report Summary Diff📊 Fitter Summary (.fit.summary)No baseline available from main branch View PR synthesis results⏱️ Timing Analysis Summary (.sta.summary)No baseline available from main branch View PR synthesis resultsComparing synthesis results from main branch vs. this PR |
Member
|
Thanks for the PR! Let us merge #190 first, so that you can use the |
Comment on lines
+1
to
+13
| // Zbs: Single-Bit Operations (RV32) | ||
| // | ||
| // Implements: | ||
| // - bclr / bclri | ||
| // - bset / bseti | ||
| // - binv / binvi | ||
| // - bext / bexti | ||
| // | ||
| // Design note: | ||
| // - Purely combinational ALU block | ||
| // - reg2[4:0] used as bit index | ||
| // - R/I distinction handled in decoder | ||
|
|
Member
There was a problem hiding this comment.
for the documentation here I would just specify the section of the specification that corresponds to Zbs extension
Comment on lines
+15
to
+16
| input logic [31:0] reg1 // rs1 operand | ||
| , input logic [31:0] reg2 // rs2 or immediate (bit index source) |
Member
There was a problem hiding this comment.
Suggested change
| input logic [31:0] reg1 // rs1 operand | |
| , input logic [31:0] reg2 // rs2 or immediate (bit index source) | |
| input data_t reg1 // rs1 operand | |
| , input data_t reg2 // rs2 or immediate (bit index source) |
I think we can use data_t here, let's check if that works for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RV32 Zbs single-bit operations:
Design follows abstract ALU pattern: