Moves CustomCS to CS class#77
Conversation
|
Thanks for tackling this one, it has been top on my todo list for a while. I took a stab at adding some tests for exceptions that would be raised to think through how customizing a CS class should work. I'd prefer not to have a flag when calling We could expand the documentation for the CS class to explain what is allowed, and the exception handling will provide additional clarification. We could have an attribute that is set to indicate whether the CS is |
|
In case it's not clear, here is what I'm thinking for the
|
I've moved the CustomCS constructor into the CS class constructor.
I also added a flag for whether or not the CS class is customized, however, this is mainly for whether or not to make the
"cs_id" = Noneif neither themetadataor thedatais provided. From the description ofCustomCSit seems like the user needs at least one ofmetadataordataif we are building from an existing CS dataset, so in that case we wouldn't need this flag. But in the tests, we can createCustomCSinstances without providing either, so in that case we would need the extra flag, so please let me know what you think.Addresses #12