test: raise coverage from 73% to 100% statements - #3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Baseline
vitest run --coveragewas 73.69% statements / 75.63% branches, with the gaps concentrated in modules that had no test file at all. This adds unit tests for those, taking coverage to 100% statements / lines, 95.95% branches without touchingsrc/.Where the coverage was missing and what now covers it:
formatter.tstest/formatter.test.ts— everystatusIconbranch, each report section, the 20-entry cap on the valid-links list, redirect-chain printing (only when >1 hop), broken links with/without occurrences, summary footerindex.tstest/index.test.ts— asserts the exact export surface, so a dropped re-export fails a testchecker.tsperformRequesttest/checker.request.test.ts— HEAD→GET fallback on 405/501 and on throw, multi-hop chains, relativeLocationresolution, 3xx withoutLocation,Too many redirects (> 10)report.tstest/report.write.test.ts—writeJsonReport/writeMarkdownReportagainst a temp dir, remainingstatusEmojicases, duplicate/insecure/chain issue linesscanner.tstest/scanner.events.test.ts—onFileFound/onLinkCheckedordering and index/total, single-file and trailing-slash paths, non-markdown direct path, timeout/malformed/redirect/http counters, empty scanperformRequestis unreachable through therequestFnseam that existing tests use, so its test file mocksaxios.createand injects fakehead/get:One config change:
src/action-entry.tsis added to the coverageexcludelist. It is a 3-line shim (void runAction()) around the already-excludedsrc/github.ts, so it was reporting 0% and depressing the total for no signal.Remaining uncovered branches are defensive
?? ''fallbacks inmarkdown.ts(unreachable given the regexes) and the two real-network defaults inscanner.ts.Link to Devin session: https://app.devin.ai/sessions/57116b8344064675a8572be9cf98e16b
Requested by: @lahcenassmira