Repository navigation
chore: template 8ebc131, and each check once (no cargo job) - #48
Merged
Merged
Conversation
The universal policy files from template 8ebc131, on this repository's existing SDK (prismpm-sdk-candidate 36da25ef) and action (f785ee46), so prismpm.lock, standards.lock and the devcontainer are unchanged. Of the four copied files only bootstrap.yml differs: a newer push to a pull request now cancels its older run, a pull request runs acceptance once on amd64 while main and tags run both architectures, and checkout runs on Node 24. template.lock is recomputed by render.mjs's lock step. The template-update workflow could not produce this: its prismpm template check runs just model-write, which compiles xtask, in a --network none container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MhcQEwMfZSDWaZCJd
… no cargo job `just vv` ran check-model and audit-bootstrap twice (template-check, then inside xtask validate), the repo-conformance tests twice (test, then bdd), and the workspace through two compilers that differ only in features (lint, then features). Now model is the one xtask validate, template-check is the SDK's two checks, and lint is Clippy with --all-features. Every Cargo call is --locked. bdd stays as a slice outside vv. lexlean.yml's cargo job ran the same fmt, Clippy, feature build, xtask gates, deny and tests outside the SDK again; the bootstrap acceptance job's `just vv` runs each in the locked SDK, and xtask validate includes audit-dependency-updates through bootstrap::audit, so the job is removed. CF-08 held the cargo job to installing no suite and setting no root; it now holds `just test`, the workspace gate, to the same, and a planted MCP_CONFORMANCE_SUITE_ROOT in that recipe fails it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MhcQEwMfZSDWaZCJd
…load the hidden patch The template check compiles the project's xtask with no network, but the SDK's Cargo home holds only the SDK's crates. A credential-free step now fetches the locked crates first. upload-artifact also skipped the dot-file patch, so the proposal job failed after a successful render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MhcQEwMfZSDWaZCJd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three commits. Each stands on its own.
1. Update the locked template contract to 8ebc131
This brings in the universal policy files from template 8ebc131, on this repository's existing SDK (
prismpm-sdk-candidate@sha256:36da25ef…) and action (f785ee46).prismpm.lock,standards.lockand the devcontainer are therefore unchanged. Of the four copied files, onlybootstrap.ymldiffers:actions/checkoutruns on Node 24.template.lockbinds 8ebc131, and render.mjs's own lock computation produced it. Moving to the template's newer SDK (cd3b47d7) would replace this repository'sstandards.lock, which needs an explicit standards review, so that is left as its own decision.template-update.ymlcouldn't produce this commit at first. Commit 3 fixes it.2. Run each check once
The same change as UOR-Foundation/lexlean-mcp#68 and UOR-Foundation/template#27:
modelis the onextask validate.template-checkis the SDK's two checks.lintis Clippy with--all-features --all-targets, which replaces the separatefeaturesbuild.bddleavesvv, becausetestalready runs it.--locked.It also removes
lexlean.yml'scargojob, which reran all ofjust vv's checks outside the SDK. Theconformancejob, which installs the suite and runs the ignored oracle tests, is unchanged.CF-08 held the
cargojob to installing no suite and setting no root. It now holdsjust test, the workspace gate thatjust vvruns in the SDK, to the same rule. A plantedMCP_CONFORMANCE_SUITE_ROOT=/xin that recipe fails it with "the workspace gate uses MCP_CONFORMANCE_SUITE_ROOT".3. Fix the template-update workflow (template#29)
xtask, but the SDK's Cargo home holds only the SDK's crates. A credential-freecargo fetch --lockednow fills a temporary Cargo home first, and the check runs offline against it. It prints its JSON if it fails.upload-artifactskips dot files by default, so.template-update.patchwas never uploaded. The step now setsinclude-hidden-files: true.With both fixes, lexlean-mcp's dispatch run 41209165931 rendered a proposal byte-identical to its own update commit.
Verification
Run locally:
cargo fmt --checkpasses.cargo clippy --workspace --all-targets --all-features --locked -- -D warningspasses.cargo test --workspace --locked --no-fail-fast, without the suite root, passes with 0 failures after the CF-08 change.xtasktests pass on the updatedbootstrap.yml.prismpm template check,lock checkand the fulljust vvrun in this PR's bootstrap job.Generated by Claude Code