Repository navigation
Conversation
Every pull request edited CHANGELOG.md's `## Unreleased` list, so each landing on a release line made every open pull request conflict and restart its gate. A pull request now adds `changes/<slug>.md` instead. `cargo xtask bump-version` folds the Unreleased entries, then every fragment in file-name order, under `## X.Y.Z` below an empty `## Unreleased`, and deletes the fragments; on failure every file, the deleted fragments too, is restored. validate-model refuses a fragment that is empty, holds a `#`/`##` heading, or is not `.md`, and the deferral audit scans `changes/`. AGENTS.md and SPEC.md §9.4 say contributors add a fragment and never edit CHANGELOG.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MAztfvN671cYrybev
afflom
left a comment
There was a problem hiding this comment.
Bounded source review: moving each PR's release entry to a separate fragment addresses the demonstrated CHANGELOG merge-conflict churn. The transactional snapshots include version files, fragments and Cargo.lock before mutation; the rollback paths and deferral-audit inclusion are coherent in this source review. Existing cut/land/tag control is retained. Owner-reported tests are scoped evidence, not a measured CI saving or final acceptance.
P2 — xtask/src/bump.rs:100–116, fragment_fault: the fence boolean accepts an unclosed opening ``` and returns None at EOF. Once folded into CHANGELOG.md, that fragment can turn later fragments and existing release headings into code until another fence occurs. It also toggles on a three-backtick line inside a four-backtick fence, which is not a valid close, and misses valid headings indented up to three spaces (for example ## 0.9.0). Thus inputs accepted by validate-model can violate the promised release-section boundary.
Please make this small validator track the actual fence marker/length and require closure, and detect allowed-indentation ATX headings outside fences, retaining valid fenced examples. Add focused cases for an unclosed fence, a too-short closing fence, and an indented heading before the next qualification cycle. No completed gate, producer or local test was repeated here; implementation remains with the current owner.
The fragment check toggled on any line starting with three backticks, so an unclosed fence passed (and would swallow later sections once folded), a shorter run closed a longer fence, and an ATX heading indented by up to three spaces was missed. Fences now track their marker and length, must close, and headings are read with CommonMark's indentation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MAztfvN671cYrybev
|
e0751d0 fixes
New cases cover:
The valid fenced examples still pass. Generated by Claude Code |
|
The red Generated by Claude Code |
afflom
left a comment
There was a problem hiding this comment.
Bounded follow-up at e0751d0: the prior fragment-validation P2 is resolved in source. The validator tracks fence character and opening length, closes only with a sufficient matching run, refuses a fence left open at EOF, and detects level-one/two ATX headings with up to three leading spaces. The focused cases cover the previously reported unclosed fence, too-short close and indented heading while preserving valid fenced examples and indented code.
The one-file delta leaves folding, transaction rollback and existing release controls unchanged. No new blocker found in this bounded repair; prior source review credit is reused. Owner-reported local tests remain scoped evidence. Current exact-head CI/reproducibility and actual merged-tree acceptance are still required; the canceled91a827 run is not aggregated into success. No local test, producer or gate was repeated here.
The workflow-token push of a cut's regenerated patch starts pull_request runs that wait for approval and complete as action_required. await-gate.sh took the newest such run as the gate and failed the v0.4.3 cut (run 43701488279) while the dispatched gate was still running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MAztfvN671cYrybev
afflom
left a comment
There was a problem hiding this comment.
Bounded follow-up at b617cfc: the two-file change repairs the demonstrated #551 wait failure. The preserved failed-job132798591656 log shows await-gate selected completed action_required CI43709775331 and exited1 while the eligible dispatched gate remained pending. The new filter excludes only approval-pending action_required results; failed/canceled runs are still failures, no eligible run continues waiting, and a successful candidate still goes through the unchanged whole-gate validator.
No new blocker found in this repair; prior e075 changelog-plant repair credit remains scoped. This grants no automatic cut retry or release acceptance, and does not relax the standing Intel/full-premerge or STOP boundaries. Current exact-head CI is queued and reproducibility passed; final-head full acceptance and actual-tree equality remain required. No tests/gates/writers repeated. Independent receipt ef248a2715e1a4a3b20cbf28343a10ac4ba514241e1f109f2009150e088ea402; sole failure log SHA919ba540fe9b9ce7e1b8d4d3609700e39001179285f068b86458900e6f5432e8 retained.
|
Generated by Claude Code |
afflom
left a comment
There was a problem hiding this comment.
Attempt2 of43709974315 is not qualified:65 successful jobs, one failed ARM Linux job and three Intel obligations skipped. The sole fetched ARM log132837774577 reports runner shutdown at14:38:49, then operation cancellation during Cargo tests. It contains no failing assertion/compiler error/OOM diagnostic establishing a product defect; outstanding BS05–BS08 had not completed. Do not infer timeout, memory exhaustion or source correctness from this interruption.
The actual checkout in this log is synthetic merge6444ba6d, not a direct b617 checkout. Preserve attempt1 and attempt2 separately and retain successful scopes; no canceled or unfinished job is acceptance. Existing owner should disposition the unfinished ARM lane using available runner/run incident evidence; no automatic retry or new gate is requested here. Prior bounded selector/changelog source reviews remain unchanged, with standing final-head/full-gate/actual-tree requirements.
Log SHA798cddf7a1d46758aebdf6a6b204189ee8423fe941faf08dd56e669a6f4ebb1b; diagnostic receiptd142948fadde8890a45ed87cdf468b0be54d65e4ef0c49ba319584a74b2bafda. COMMENT only.
Brings #536 (the AU-01 corpus memory fix) and the line's other landings; the aarch64 cargo-test leg lost its runner twice on the older base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3MAztfvN671cYrybev
|
The aarch64 Linux cargo-test job lost its runner on both attempts, both times while
Generated by Claude Code |
|
The aarch64 Linux runner was lost again on 4353bcd (job 132871560408), even with #536 merged in. Again it went down during BS-05..08 with no failing test. It has now happened on this PR's heads and on #551's gate, so it isn't caused by this diff, which touches xtask, workflows and docs and doesn't affect the BS cases. I've handed the runner memory investigation to the CI gate work, and this PR waits on that rather than on more re-runs. Generated by Claude Code |
afflom
left a comment
There was a problem hiding this comment.
The incident's tested-source binding needs one correction: attempt2 checked out synthetic6444ba6d, whose parents already include ab91576 and hence #536 actualf76a. Old checkout6444, new head4353 and new checkout4644dbfc all have the exact same tree9ee16cd6. This merge changes branch ancestry but did not introduce #536 into the previously tested composition. Prior b617 source-review credit is preserved; no new merge-composition defect found.
The one new retained log132871560408 confirms runner shutdown at16:34:59 and cancellation16:35:00 during unfinished Cargo tests; BS05–BS08 had not finished. It does not establish OOM, a product defect, a hang or a platform cause. Log SHA07f5d440936735b48ee9a537c763bc82028d99b091e940ec20b1bbcb3715fb0b; previous logs were reused locally, not fetched again.
Keep the current handoff to the existing CI investigation and the owner's no-more-reruns decision. Its concrete next result is a retained cause/disposition for the unfinished ARM lane, followed by applicable full final-head qualification; neither tree equality nor successful neighboring jobs supplies that acceptance. Receipt b6bb20cce6a9bb24d75cf177b9e2a836a93da02c5498bcfd8d18473c27b984eb. COMMENT only; no retry/control action.
Requested by Alex · project thread
Today every landing on
release/v0.4makes every open pull request conflict on CHANGELOG.md's## Unreleasedlist. Each re-merge then restarts the ~3.5 h gate; #518 alone did this to #529, #503 and #543. Amerge=unionattribute would not help, because GitHub's mergeability check ignores it. With this change, pull requests addchanges/<slug>.mdand never edit CHANGELOG.md, so they don't conflict there.cargo xtask bump-version, whichcut.ymlruns:## Unreleasedentries, then eachchanges/*.mdin name order, under## X.Y.Z## Unreleasedand deletes the fragmentsCargo.lockvalidate-modelchecks every fragment: it must be.md, non-empty, and have no#/##heading outside a fence. A bad fragment fails its own pull request, not the cut.changes/.Checked locally:
cargo test -p xtask: 24 pass, 3 of them new: fold order, restore on a late failure, and the fragment rules.validate-model,validate-spec-links,cargo fmt --checkandclippy -D warningson xtask all pass.bump-version 0.4.2with two demo fragments folded all three in name order and emptiedchanges/.Generated by Claude Code