Repository navigation
BS-50..52: the lexicon schema, LSE scopes and LSE type checker as source, batch (#269) - #525
humuhumu33 wants to merge 3 commits into
Conversation
…(BS-50..52, #269) One batch branch carrying three independent slices of the lexicon closure, as BS-25..34 landed in #480: - BS-50 LexiconSchema: the category/frame/channel/associativity/feature tables and surface_safety/is_lean_name/toml_comment_at/entry_path, over the atoms of BS-03. Six roots. - BS-51 LseScopes: Lse::check_scopes, referenced_consts, and outer_explicit_binders/result, over the expressions of BS-25. Three roots. - BS-52 LseTypes: the conservative checker, check_signature and check_value, structural over a host-given nesting bound. Two roots. Register rows (model/ids.toml, SPEC §31, VERIFICATION.md, features scenarios) are inserted as one whole block per slice, in register-ID order, after BS-34. Counts and totals that the regeneration itself writes (README.md, CHANGELOG.md, the §31 total line, repository.rs's and spec_links.rs's row counts) are left at release's current values for the regeneration to fix. .github/workflows/regenerate.yml is release's version overwritten with the fixed one from ci/regenerate-relocks (the deliver job and a relock step that survives combine), so this branch's own regeneration lands itself onto the PR opened for this batch branch. #522, #523 and #524 stay open as the per-slice record; they are not what lands. Branched from release/v0.4 at 6a02d2c. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
afflom
left a comment
There was a problem hiding this comment.
Independent bounded review credits this canonical source batch. All three authored module blobs exactly match both the prior #500/#501/#502 implementations and the new #522/#523/#524 records; all six module/case files match the new record PRs. The inspected old BS50/BS52 case differences are formatting, and BS51 is exact. Prior source and historical WSL/native evidence retain their original scope without repeating them.
The one-commit21-path union is based on actual6a02 and contains BS50/51/52 once in499 unique register rows, their three scenarios and11 roots. It does not adopt generated products; the release-baseline CONFORMANCE/census and removed bootstrap lock are explicitly pending the existing canonical regeneration43513833545. The shared-lock workflow repair has separate review5898706789. This is concrete consolidation credit, not product or full-gate acceptance.
Finish/disposition that existing batch's exact-source outputs, account for applicable preserved outputs rather than starting another producer merely for publication, then review the official projections/current products and final qualification. Keep per-slice historical evidence and owner scopes intact. Small body correction: the BS51 record should link #523, not the superseded #501. No original failure, log, native comparison or writer was repeated.
SPEC.md's "Total required capability IDs", xtask/src/spec_links.rs's RP-07 check, and repository.rs's RP-07 assertion still said 496: none of them is written by a recipe (cargo xtask counts --write carries the counts a bootstrap case reports, not the §31 row count), so the finish job would not have fixed them and RP-07 would fail after the whole regeneration. All three now read 499, matching model/ids.toml's 499 rows and SPEC §31's 499 rows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
afflom
left a comment
There was a problem hiding this comment.
The complete c453→ebe delta corrects three register-count mirrors from496 to499: SPEC total, RP07 repository assertion and spec-links check/diagnostic. Strict register/table checks remain. This resolves that source census mismatch without claiming a runtime pass. Module/case/config/workflow/product files are unchanged, so prior canonical-composition credit5898723411 is retained.
The body should now distinguish these authored count corrections from the still-pending official projection/products, and point BS51's record to #523. Existing exact-head regeneration43522949879 is queued; disposition/adopt its coherent outputs and complete resulting-head qualification. Older canceled runs do not aggregate into acceptance; no replacement producer or historical check is requested merely for publication.
The write recipes of SPEC.md §9.2, run by regenerate.yml (https://github.com/UOR-Foundation/LexLean/actions/runs/43522949879), rewrote 1452 paths. The counts writer reported: BS-05 COMMITTED_CRATES: 306 -> 317 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 COMMITTED_MANIFESTS: 330 -> 341 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 COMMITTED_PROGRAMS: 247 -> 258 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 EVALUATOR_CORRESPOND: 322 -> 328 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 EVALUATOR_CRATES: 221 -> 227 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 EVALUATOR_VALIDATE: 457 -> 463 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 VECTORS_CORRESPOND: 407 -> 418 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-05 VECTORS_VALIDATE: 542 -> 553 (crates/conformance/src/cases/bootstrap/rust_validate.rs) BS-06 COMMITTED_CRATES: 306 -> 317 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 COMMITTED_DISTINCT: 612 -> 634 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 COMMITTED_MANIFESTS: 330 -> 341 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 COMMITTED_PACKAGES: 330 -> 341 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 COMMITTED_PROGRAMS: 247 -> 258 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 EVALUATOR_CRATE: 612 -> 629 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 REFUSED_CRATE: 71 -> 73 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 VECTORS_CRATE: 785 -> 809 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-06 VECTORS_EXPR: 2265 -> 2326 (crates/conformance/src/cases/bootstrap/rust_print.rs) BS-07 VECTORS: 381 -> 392 (crates/conformance/src/cases/bootstrap/rust_lower.rs) BS-07 VECTORS_WITHIN: 296 -> 302 (crates/conformance/src/cases/bootstrap/rust_lower.rs) BS-08 CRATES: 440 -> 451 (crates/conformance/src/cases/bootstrap/rust_moves.rs) BS-08 WITHIN: 355 -> 361 (crates/conformance/src/cases/bootstrap/rust_moves.rs) BS-11 EVALUATOR_MUTANTS: 283 -> 278 (crates/conformance/src/cases/bootstrap/rust_bodies.rs) BS-12 EVALUATOR_MUTANTS: 152 -> 157 (crates/conformance/src/cases/bootstrap/rust_succeed.rs) BS-13 EVALUATOR_MUTANTS: 143 -> 157 (crates/conformance/src/cases/bootstrap/rust_loops.rs) BS-13 VECTORS: 150 -> 161 (crates/conformance/src/cases/bootstrap/rust_loops.rs) BS-13 VECTORS_WITHIN: 67 -> 73 (crates/conformance/src/cases/bootstrap/rust_loops.rs) BS-14 EVALUATOR_MUTANTS: 548 -> 573 (crates/conformance/src/cases/bootstrap/rust_assemble.rs) BS-14 VECTORS: 385 -> 396 (crates/conformance/src/cases/bootstrap/rust_assemble.rs) BS-14 VECTORS_WITHIN: 300 -> 306 (crates/conformance/src/cases/bootstrap/rust_assemble.rs) BS-15 ACCEPTED: 330 -> 341 (crates/conformance/src/cases/bootstrap/rust_package.rs) BS-15 MANIFESTS: 349 -> 360 (crates/conformance/src/cases/bootstrap/rust_package.rs) BS-15 RENDER_MUTANTS: 330 -> 341 (crates/conformance/src/cases/bootstrap/rust_package.rs) BS-05: §31 row: 221 -> 227 (x1), 247 -> 258 (x1), 306 -> 317 (x1), 330 -> 341 (x1), 407 -> 418 (x1), 542 -> 553 (x1) BS-05: the §31 row does not state 322 (-> 328) BS-05: the §31 row does not state 457 (-> 463) BS-05: register: 221 -> 227 (x1), 247 -> 258 (x1), 306 -> 317 (x1), 330 -> 341 (x1), 407 -> 418 (x1), 542 -> 553 (x1) BS-05: scenario: 221 -> 227 (x1), 247 -> 258 (x1), 306 -> 317 (x1), 330 -> 341 (x1), 407 -> 418 (x1), 542 -> 553 (x1) BS-06: 3050 is VECTORS_CRATE + VECTORS_EXPR: -> 3135 BS-06: §31 row: 71 -> 73 (x1), 247 -> 258 (x1), 330 -> 341 (x3), 785 -> 809 (x1), 2265 -> 2326 (x2), 3050 -> 3135 (x1) BS-06: the §31 row does not state 306 (-> 317) BS-06: register: 71 -> 73 (x1), 247 -> 258 (x1), 330 -> 341 (x3), 785 -> 809 (x1), 2265 -> 2326 (x2), 3050 -> 3135 (x1) BS-06: scenario: 71 -> 73 (x1), 247 -> 258 (x1), 330 -> 341 (x3), 785 -> 809 (x1), 2265 -> 2326 (x2), 3050 -> 3135 (x1) BS-07: §31 row: 296 -> 302 (x1), 381 -> 392 (x1) BS-07: register: 296 -> 302 (x1), 381 -> 392 (x1) BS-07: scenario: 296 -> 302 (x1), 381 -> 392 (x1) BS-08: §31 row: 355 -> 361 (x1), 440 -> 451 (x1) BS-08: register: 355 -> 361 (x1), 440 -> 451 (x1) BS-08: scenario: 355 -> 361 (x1), 440 -> 451 (x1) BS-11: §31 row: 283 -> 278 (x1) BS-11: register: 283 -> 278 (x1) BS-11: scenario: 283 -> 278 (x1) BS-12: §31 row: 152 -> 157 (x1) BS-12: register: 152 -> 157 (x1) BS-12: scenario: 152 -> 157 (x1) BS-13: §31 row: 143 -> 157 (x1), 150 -> 161 (x1) BS-13: the §31 row does not state 67 (-> 73) BS-13: register: 143 -> 157 (x1), 150 -> 161 (x1) BS-13: scenario: 143 -> 157 (x1), 150 -> 161 (x1) BS-14: §31 row: 385 -> 396 (x1), 548 -> 573 (x1) BS-14: register: 385 -> 396 (x1), 548 -> 573 (x1) BS-14: scenario: 385 -> 396 (x1), 548 -> 573 (x1) BS-15: §31 row: 330 -> 341 (x2), 349 -> 360 (x1) BS-15: register: 330 -> 341 (x2), 349 -> 360 (x1) BS-15: scenario: 330 -> 341 (x2), 349 -> 360 (x1) SPEC.md:8624: 283 -> 278 (every holder) SPEC.md:8551: 355 -> 361 (every holder) SPEC.md:8550: 330 -> 341 (every holder) SPEC.md:8548: 440 -> 451 (BS-08) SPEC.md:8510: 152 -> 157 (BS-12) SPEC.md:8510: 296 -> 302 (every holder) SPEC.md:8507: 381 -> 392 (every holder) SPEC.md:8425: 330 -> 341 (every holder) SPEC.md:8424: 67 -> 73 (every holder) SPEC.md:8408: 2,265 -> 2,326 (BS-06) SPEC.md:8405: 330 -> 341 (every holder) SPEC.md:8403: 2,265 -> 2,326 (BS-06) SPEC.md:8402: 71 -> 73 (every holder) SPEC.md:8401: 330 -> 341 (every holder) SPEC.md:8400: 330 -> 341 (every holder) SPEC.md:8399: 247 -> 258 (BS-05) SPEC.md:8398: 785 -> 809 (every holder) SPEC.md:8398: 3,050 -> 3,135 (every holder) SPEC.md:8397: 330 -> 341 (every holder) SPEC.md:8340: 306 -> 317 (every holder) SPEC.md:8340: 221 -> 227 (every holder) SPEC.md:8336: 407 -> 418 (every holder) SPEC.md:8335: 542 -> 553 (every holder) SPEC.md:8325: 306 -> 317 (every holder) SPEC.md:8323: 330 -> 341 (BS-05) SPEC.md:8323: 247 -> 258 (BS-05) VERIFICATION.md rows for the landing (counts | before | after): | `BS-05` COMMITTED_CRATES, COMMITTED_MANIFESTS, COMMITTED_PROGRAMS, EVALUATOR_CORRESPOND, EVALUATOR_CRATES, EVALUATOR_VALIDATE, VECTORS_CORRESPOND, VECTORS_VALIDATE | 306, 330, 247, 322, 221, 457, 407, 542 | 317, 341, 258, 328, 227, 463, 418, 553 | | `BS-06` COMMITTED_CRATES, COMMITTED_DISTINCT, COMMITTED_MANIFESTS, COMMITTED_PACKAGES, COMMITTED_PROGRAMS, EVALUATOR_CRATE, REFUSED_CRATE, VECTORS_CRATE, VECTORS_EXPR | 306, 612, 330, 330, 247, 612, 71, 785, 2,265 | 317, 634, 341, 341, 258, 629, 73, 809, 2,326 | | `BS-07` VECTORS, VECTORS_WITHIN | 381, 296 | 392, 302 | | `BS-08` CRATES, WITHIN | 440, 355 | 451, 361 | | `BS-11` EVALUATOR_MUTANTS | 283 | 278 | | `BS-12` EVALUATOR_MUTANTS | 152 | 157 | | `BS-13` EVALUATOR_MUTANTS, VECTORS, VECTORS_WITHIN | 143, 150, 67 | 157, 161, 73 | | `BS-14` EVALUATOR_MUTANTS, VECTORS, VECTORS_WITHIN | 548, 385, 300 | 573, 396, 306 | | `BS-15` ACCEPTED, MANIFESTS, RENDER_MUTANTS | 330, 349, 330 | 341, 360, 341 | For a reader: BS-06 COMMITTED_DISTINCT: 612 is also the value of ["EVALUATOR_CRATE"]; rewrite its statements by hand (612 -> 634) BS-06 EVALUATOR_CRATE: 612 is also the value of ["COMMITTED_DISTINCT"]; rewrite its statements by hand (612 -> 629) BS-14 VECTORS_WITHIN: 300 is also the value of ["EVALUATOR_NODES"]; rewrite its statements by hand (300 -> 306) SPEC.md:8516 still states 150 (-> 161 for BS-13?) before "mutants), and 874 seconds for `siteTree" SPEC.md:8552 still states 150 (-> 161 for BS-13?) before "seeded mutants of the crates of at most" SPEC.md:8587 still states 150 (-> 161 for BS-13?) before "seeded runs, the rendered package on 1," written; next: cargo xtask validate-model --write, then the parts without LEXLEAN_COUNTS
One batch branch carrying three independent slices of the lexicon closure, as BS-25..34 landed in #480.
surface_safety/is_lean_name/toml_comment_at/entry_path, over the atoms of BS-03. Six roots. (Record: BS-50: the tables and predicates of the lexicon entry schema as source (#269) #522)Lse::check_scopes,referenced_consts, andouter_explicit_binders/result, over the expressions of BS-25. Three roots. (Record: BS-51: the scopes, references and outer shape of an LSE expression as source (#269) #501)check_signatureandcheck_value, structural over a host-given nesting bound. Two roots. (Record: BS-52: the conservative checker of LSE expressions as source (#269) #524)Register rows (model/ids.toml, SPEC §31, VERIFICATION.md, features scenarios) are inserted as one whole block per slice, in register-ID order, after BS-34. Counts and totals the regeneration itself writes (README.md, CHANGELOG.md, the §31 total line, repository.rs's and spec_links.rs's row counts) are left at release's current values for the regeneration to fix.
.github/workflows/regenerate.ymlis release's version overwritten with the fixed one fromci/regenerate-relocks(the deliver job and a relock step that survives combine), so this branch's own regeneration lands itself onto this PR.#522, #523 and #524 stay open as the per-slice record; they are not what lands.
🤖 Generated with Claude Code