Repository navigation
ci: regenerate.yml, the write recipes on runners - #467
Conversation
A dispatch on a ref runs the production export, the verification records and the other oracle writers as three jobs from clean checkouts of that commit, and a final job combines their patches into one, refusing two that write one path. It reads the repository and writes nothing to it; the patch is reviewed and committed like any other written output (§28.3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub dispatches only a workflow its default branch carries, so a push to a branch under regenerate/ starts it from any commit; regenerate/atlas/ includes UOR Atlas's records. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
afflom
left a comment
There was a problem hiding this comment.
Bounded source review of a66bd0c against bc71b33.
P2 — enforce the promised shared-path rejection in .github/workflows/regenerate.yml:128–132. The writer saves each .files manifest, but combine never reads or intersects them: it only applies the three patches sequentially. Two patches changing distant hunks of the same existing file both pass git apply --index; I confirmed this in an isolated Git fixture. Thus a successful combine does not establish the path disjointness promised by the workflow comments and SPEC §9.4. Please reject duplicate paths across the parts before applying them, preserving binary-patch support.
The official write recipes and separate final gate remain intact. The current smoke run is still pending, and draft CI skips the required host/Atlas groups; neither establishes final acceptance. Also, verify-write checks existing locks rather than producing them, so this workflow still requires correctly prepared inputs when identity or configuration changes. This is review feedback for the existing owner; no competing writer or qualification run was launched.
|
The project owner has made PrismPM's Prism/factory integration an explicit LexLean v0.5 release requirement, now tracked in #468 and #128. I inspected published PrismPM v0.4.0 at b48ee2: it ships modeled source/build evidence reuse; the broader certified scheduler in PrismPM#586 remains unmerged. This preserves your ownership of #467's writers, collision repair and qualification. Root will own the separate LexLean factory model/evidence-contract integration and coordinate the exact adapter/file boundary before overlapping changes. #467 is the producer lane to reuse, not a reason to launch another regeneration workflow. The eventual supported developer path must use the model's routing and retire duplicated orchestration while retaining all proof/full-head/host/Atlas/repro requirements. Current producer runs and their evidence remain untouched. |
# Conflicts: # CHANGELOG.md
…bounds A fourth job, after combine, applies the regenerated tree, runs the parts that hold a crate::counts! check under LEXLEAN_COUNTS=fast, writes the moved counts (cargo xtask counts --write) and the model documents, and measures the stack bound of each recursive package the record lacks with a whole run of the case that names its root. The patch it returns is the whole landing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves the landing regeneration off workstations. A change that moves committed output (the production export, the verification records, golden, fixtures, calculus targets, the model documents) has been regenerated on a contributor's machine: hours per PR, and repeated out-of-disk failures under WSL.
What it does
regenerate.yml(SPEC.md §9.4, new paragraph) is not part of the gate.git push origin <commit>:refs/heads/regenerate/<name>. Useregenerate/atlas/<name>to include Atlas. Once the workflow is onmain,gh workflow run regenerate.yml --ref <branch> [-f atlas=true]also works. The push trigger exists because GitHub dispatches only workflows that are on the default branch; I confirmed this on this branch (HTTP 404).production-export-write;verify-write, which covers every example but UOR Atlas, or every example withatlas=true;golden-write fixtures-write calculus-write model-write.examplesleg. The jobs verify at width 2 with the committed hints and the 12 GiB budget. Per §22.11 this changes no written byte.combineapplies the three patches in turn to a clean checkout and fails if two of them write the same path. It uploadsregenerated-<commit>, which holds the patch, its path list, the base commit andSHA256SUMS. The step summary prints the two commands to apply it.finishwrites everything that follows from the regenerated tree (added inf952ed564):LEXLEAN_COUNTS=fast, the parts of.github/bdd-parts.jsonthat hold acrate::counts!check, then runscargo xtask counts --write(Bootstrap count cases: report every moved count in one pass, and write them #442). Today those are the nine bootstrap parts, about 5 min.validate-model --write.recursioneffect in itsprovenance.json) that has no row intests/stack-bounds.json. For each one, it runs the case whose source names the package's root, in measure mode. That is a whole run of the case, so it also checks the counts just written. Rows of packages no longer exported are dropped.regenerated-<commit>with the writer's report in the step summary. Anything the writer could not place is listed there for a reader.crate::counts!checks skips the counts step and says so.contents: read, keeps no credentials, and pins actions by SHA, with the same pins asci.yml. The patch is reviewed and committed like any written output (§28.3), and the gate then verifies that tree.Measured effect
Run 43027788154 took 85 minutes from start to finish:
The previous single-job runner writer took 158 minutes (run 42757642108). Local WSL regenerations took longer and ran out of disk. The records job is now the slowest of the three; splitting it by example would be the next cut. A run that includes Atlas has not been measured.
Verified
cargo xtask validate-model: documents current, 482 ids.cargo xtask validate-spec-links: passed.cargo test -p repo-conformance --test conformance -- conformance_rp_: 17/17 pass, including RP-08 (deferral audit) and RP-14 (workflow triggers).The test run on GitHub passed with an empty patch. It ran 43027788154 on
release/v0.4plus this workflow.regenerated.patchandregenerated-files.txtare both 0 bytes, so every writer reproduces the committed output byte for byte, including the production export at width 2.Test of the full pipeline, with
finish: run 43106639628, onrelease/v0.4plus Bootstrap count cases: report every moved count in one pass, and write them #442 plus this workflow, finished with an empty patch.finish(7 min): it chose the nine bootstrap parts that hold acounts!check, all of which exited 0 underLEXLEAN_COUNTS=fast. The writer reportedcounts: no count moved, and every recursive package already had its row.Reviewer notes
expected/verifyandexpected/build, which are disjoint.combinechecks every overlap rather than assuming it.print_tooling_modulemaps toconformance_bs_27, andprint_genericmaps toconformance_bs_24(each file's first//!line names its own case). A package whose root no case names fails the step with a message to measure it by hand.🤖 Generated with Claude Code