Repository navigation
BS-30: the terminal output of diagnostics as language-1.2 source (#274) - #456
Closed
humuhumu33 wants to merge 3 commits into
Closed
humuhumu33 wants to merge 3 commits into
humuhumu33 wants to merge 3 commits into
Conversation
…nctions cli.rs's own print_human_diagnostics is reached through the new doc-hidden public human_diagnostics_text, and wants_json and named_command become public and doc-hidden, unchanged, so that the bootstrap differential of BS-30 can call them. cli.rs is outside the compiler-semantics identity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… diagnostics The second slice of the driver as source (#274), on BS-29: the row (register 479 -> 480, the §31 table, the RP-07 check and its case), the scenario, the §17.23 prose, the CHANGELOG entry, the README's claim, the CI part, and the case, conformance_bs_30, which holds CliOutput.humanDiagnostics, wantsJson, and namedCommand to cli::human_diagnostics_text, wants_json, and named_command on hand-built diagnostics and arguments, on the negative fixtures' committed diagnostics and commands, and on seeded ones, with 15 planted defects each named by its vector. VERIFICATION.md records the first run: the evaluator agrees on 817, 515, and 512 runs, rustc on 4,244, and every plant is detected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bootstrap/src/CliOutput.lex.tex over Diagnostics: humanDiagnostics writes a failure's diagnostics as the command line writes them to stderr, with the SGR palette or without; wantsJson and namedCommand scan the arguments after the program. Lean verifies the module and each root is eligible with exactly allocation. The entrypoint, the lock, the three export roots, and the project README follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Landed in #480 (merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #274: the terminal output of diagnostics and the argument pre-scans of the command line (
BS-30,cli.rs) as language-1.2 source, with rootshumanDiagnostics,wantsJson, andnamedCommandofCliOutput. It is the second slice of the driver.Draft, stacked on #455 (
BS-29).CliOutputwrites the diagnostic type ofBS-29.Design
humanDiagnosticswrites each diagnostic of a failure as the command line writes it to stderr in the human mode:error[CODE]: message, the primary location after an arrow, then its labels, notes, help, and causes one to a line, with the four SGR sequences of the palette around the parts the oracle colors, or none.wantsJsonfinds--diagnostic-format=json, or--diagnostic-formatfollowed byjson, among the arguments after the program, before they are parsed, so that a usage failure is reported in the JSON mode.namedCommandfinds the first argument after the program that names one of the ten commands. Each root admits exactlyallocation. Parsing the arguments, choosing color for a terminal, and the JSON command result stay in the host.The oracle. These three are private in
cli.rs, so the first commit exposes them unchanged:print_human_diagnosticsbehind a new doc-hidden publichuman_diagnostics_text, andwants_jsonandnamed_commandmade public and doc-hidden.cli.rsis outside the compiler-semantics identity, so nothing regenerates for it.Evidence
Measured on the normative host on #455 over
release/v0.4at4318b17b8:Lean verifies the module, and the eligibility report gives each root exactly
allocation.Gates at the head
cargo fmt --check,validate-model(480 IDs),validate-spec-links(480 rows), clippy on the workspace with-D warnings, and the 17 RP cases pass.CI is expected red until the regeneration
The three packages are not committed, so
conformance_bs_30stops at the stack-bound step after the differentials above have agreed. The regeneration owes them, with #455's.🤖 Generated with Claude Code