Repository navigation
Conversation
Retain the 128-level reader bound and recursion-limit category, explain smaller definitions joined by prim append, and cover the boundary and validation refusals. Closes #375.
Retain both VERIFICATION records after their append-only conflict. Model, specification links, formatting and diff checks pass on the resolved tree.
Comment only: retain the 240-minute timeout and every workflow token. Closes #235.
afflom
left a comment
There was a problem hiding this comment.
Independent maintainer review of the implementation and final integration is complete. The existing 128-level limit and all validation paths remain intact; only the nesting error gains a remedy and drops generated JSON coordinates. The original recursion-limit category is preserved for SP-02, and SM-12 covers accepted/refused boundaries, subsequent declarations, API/CLI forms and the split-list remedy. The advice-removal plant fails, then focused tests and model/spec/format/Clippy checks pass. The sole merge conflict preserved both VERIFICATION records exactly. The final workflow follow-up changes comments only, recording the actual Intel measurement without changing the 240-minute timeout or any executable workflow line.
Reviewed final tree: 7c32b44313f84e239ee3f6a29ec24dbd6a54583f. Source review is clear; full final-head CI remains required before merge and closure of #375/#235. This is the unchanged-limit diagnostic alternative explicitly accepted by #375, not a claim to support 1,000-element literal chains.
|
Superseded by the reviewed combined maintenance PR #403 at 39399a2. This PR's exact head 79a8da3 is a direct parent of that integration, so its history and implementation are retained. Its approved corrections and verification records are included there. Closing this duplicate landing path so the combined final tree runs one complete gate. This is not a claim that the work has landed: the linked issues remain open until #403 passes and merges into release/v0.4. Required forward propagation remains tracked by #404/#405. |
Closes #375 using its explicitly accepted alternative: keep the documented limit and make the diagnostic name the fix.
A semantic module still has the JSON reader's 128-level nesting limit, independently of max_scope_depth. The LLT4001 diagnostic now states that bound and recommends smaller list definitions joined by
prim append. It retainsrecursion limit exceededfor existing SP-02 compatibility and removes generated JSON coordinates from this diagnostic. The source span remains the semantic-module body; it does not identify the nested declaration or term. This change does not accept a 1,000-element cons chain.SM-12's existing register row and scenario now cover committed 122/123-cell list fixtures, the refusal after another declaration, and a 200-cell workaround split into two 100-cell definitions. Assertions cover the project API, human/JSON CLI output, direct semantic JSON reading, and existing malformed, noncanonical, duplicate-member and closed-schema refusals. The compiler-stack plan supplies the direct reader test's stack. All production readers and validation limits remain intact; no schemas, embedded identity inputs or compiler identities change. This is separate from #402's downstream package/program reader fix.
Validation: SM-12 passes (1.83 s), five BDD meta tests pass, validate-model reports 468 IDs/86 codes with audits clean, spec links pass, formatting and git diff checks pass, and Clippy passes for lexlean/repo-conformance with all targets/features and warnings denied. The official model writer regenerated CONFORMANCE.md. Fail-first reproduced the original recursion-limit diagnostic; removing the append recommendation makes the new assertion fail. Both records are in VERIFICATION.md. Issue #375's existing append-workaround verification evidence is cited; no new Lean verification claim is made.
The feature was validated on tree 0a1219bf1754c8c356a96e8b15f26105c27baba6; the final category-preservation adjustment passed a fresh SM-12 run (1.83 s) and formatting/diff checks. SP-02's existing recursion-limit-category assertion is preserved.
Merged release/v0.4 at 477a508 into the PR branch. The only conflict was appended VERIFICATION records; both records are retained. No generated document was edited by hand. The resolved tree 9fec49a9bec8b574d293f42296e48fda9157f3eb passed fresh validate-model (468 IDs/86 codes), specification links, formatting and diff checks. The published merge has both the prior PR head and that release base as parents and matches independently reviewed local merge 071def67a53d0494d154b0e6c0252d013ba416d2 by tree. The twelve-file feature delta is unchanged. Full remote acceptance CI remains required; this PR has not been merged.
Closes #235's remaining timing-comment acceptance item. The cost and coverage changes already landed in #400. This follow-up records the observed post-change Intel leg at 30612d2 on 2026-11-03: 117m01s total in run 41592896657, with 100m21s in conformance. The workflow comment explains that the retained 240-minute timeout is about twice that observation. This final follow-up changes only four YAML comment lines: every non-comment line and the 240-minute timeout were compared and are unchanged, and git diff --check passes. No tests were rerun for this comment-only edit. Final tree: 7c32b44313f84e239ee3f6a29ec24dbd6a54583f. Full remote acceptance CI remains required on the final head.