Repository navigation
Conversation
…cenarios and failing named tests Rows, SPEC.md §31 rows, scenarios, and conformance_<id> tests only; the four tests fail because no case is wired. No implementation, no identity moves. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
#91 stage 4's) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
The reference interpreter, the TargetSemantics denotation, and the SPEC.md 17.14 cost rules charge Expr.value its weight (one for a scalar). The case conformance_tc_08 passes; the 14 fixtures with a literal heavier than one node, their generated statements, and compiler/lexlean.lock are not regenerated, so conformance_tc_01/03/04/05 fail on this tree until the maintainer sequences it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
afflom
left a comment
There was a problem hiding this comment.
Maintainer review of TC-08 at f3376f5.
Verdict: ready for the gate with two should-fixes. The rule is charged at the one evaluation site of Expr::Value in the interpreter (interp.rs:448-451) and in the denotation (TargetSemantics.lex.tex:5260); Let evaluates its binding once, Call its body once per call, so a literal in a recursive body is charged once per read and a let-bound literal read twice is charged its weight once plus the local-read rule. No under-charge and no over-charge found; a scalar stays at 1 (§17.14). The Rust runtime ticks nothing for a literal, so TC-07/RB-06's bound keeps its direction. The test is falsifiable: steps = 1 planted in the interpreter fails at calculus.rs:1613 with string read 1 time(s) is charged its weight 4.
Should fix
VERIFICATION.md:4012-4036lacks the command run (§27.9; every neighbouring record quotes it). Addcargo test -p repo-conformance --test conformance -- conformance_tc_08.- The denotation half of the case is a source-text
contains(calculus.rs:1627-1632). A defect planted inweightitself (Value.string text => 1) passes TC-08 and is caught only by TC-03/04/05 once the 14 fixtures andcompiler/lexlean.lockare regenerated at landing. The record says so; say it in the PR body's "Not established" as well. A fixture whoserfltheorem states a weighted count would close it after regeneration; not required for this PR.
Notes
conformance_tc_01/03/04/05failing on the committed fixtures with a heavy literal is the identity move; expected until landing.- The three
LLB6005plants exercise pre-existing static rules ofcheck.rs; fine as coverage, but the statement's "refused with LLB6005" clause is not new work.
Generated by Claude Code
…e records of spec/src Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
…mand and the limit of the text check Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
|
A finding on this PR that the unregenerated tree hides: TC-08 breaks the preservation library on regeneration. With the
Options: (1) repair the library terms for the weight charge in this PR (iterate the library compile until it passes; I can do it with the same programmatic method), or (2) keep the charge out of the library by stating Generated by Claude Code |
|
Round two at 22df8de: both should-fixes met (the command line in the record, the limit of the Generated by Claude Code |
…alue v (weight v)) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
|
Library repaired (option 1), head Lemmas touched, by name (one): Measurement. With Forward-merged up the stack, each merge clean apart from one VERIFICATION.md section I resolved by keeping both: #238 Not committed, as instructed: the regenerated compiler modules and every lock. Still waiting for the landing regeneration: the items listed on this PR. Generated by Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
…rojection Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
…ojection) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
…and MD IDs (RP-11) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
… has 446 IDs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ
|
Maintainer: closed as a stacked draft whose commits are contained in #239 ( Generated by Claude Code |
Part of #115 (L3.2 of #106), PR 2 of the stack. Stacked on #228: this branch contains its commits (merged with
release/v0.5at 42ce948); the TC-08 change is the last commits.Change.
Expr.valueis charged its weight (one per node, plus a string's characters and a byte string's bytes) each time it is read, incompiler/src/TargetSemantics.lex.tex(the kernel-checked denotation),crates/lexlean/src/calculus/interp.rs(the reference interpreter) and the Cost list of SPEC §17.14. A scalar still costs one step. The TC-08 row (a record inspec/src/IdsTC.lex.tex), scenario andVERIFICATION.mdrecord are written to this, after the correction posted on #115 (the calculus already had compound literals; only the cost was missing).Library lemmas touched, by name (the maintainer's decision, option 1).
LexLeanPreservation.Rust.sem_value(RustLemmas): its term appliescongrArgtoeval.eq_2with the explicit argumentOutcome.value v 1; it is nowOutcome.value v (weight v), because the charge ofExpr.valuechanged. That is the only lemma: withTargetSemantics.leanregenerated locally,conformance_sp_13refused it first (the loader stops at the first refusal), and after the repair passes over all 13 modules, so the count was found by iteration.conformance_sp_14,_15and_16pass over the same regenerated module. Recorded inVERIFICATION.md.Gates (unregenerated tree).
cargo fmt --all --check, clippy-D warnings,validate-model(438 ids),validate-spec-links,--test bdd, andconformance_tc_02,_06,_07,_08pass.Limit of the denotation check.
conformance_tc_08checks the Lean denotation only by readingTargetSemantics.lex.texand requiring the line that chargesweight literal: a text check, not the kernel's reduction. The kernel check is the fixtures'rfltheorems, which needcargo xtask check-calculus --writefirst. The library compile above is a kernel check of the regenerated denotation against the library, not of the fixtures.Fails on this tree, by design (the landing regeneration is yours).
conformance_tc_01,_03,_04,_05: 14 of 122 committed fixtures contain a literal heavier than one node (binding-and-shapes,byte-compare,byte-order,byte-slices,bytes-and-text,decimal-overflow-wide,decimal-overflow,decimal,equality,function-shapes,literals,ordering,split-and-join,string-escapes); e.g.binding-and-shapesis committed at 39 steps and now evaluates to 51.compiler/lexlean.lockneeds relocking,language/preservation-1.2/modules/LexLeanTarget/TargetSemantics.leanregenerating (the library repair is valid only against it), andcheck-goldenreports thecompilerproject'sTargetSemanticscoverage oracle stale.Not established. No full
just vv; I did not check which other committed records embed a literal's step count.🤖 Generated with Claude Code
https://claude.ai/code/session_01NZLb4yopYgjBGQngfSuFeQ