Skip to content

Resolve the four retained source findings from the #483 efficiency batch #489

Open

Description

@afflom

#483 landed as 465b8ab with the four P2 findings from final-head review 5872966303 still unresolved. This issue preserves that bounded repair scope after the six component carriers merged; the existing batch implementer retains ownership. Account authorship is not a takeover signal.

Actual tree bd8e6423d8b58e1163a64f5617dd08fe88ff3daf equals reviewed f3b25f2. PR CI 43198040363 passed 70/70 jobs and 772/772 steps, including same-run honesty; repro 43198040382 passed. Those results are complete evidence for that tree, but do not resolve the source findings.

  • Account for concurrent caller evaluators in the process-wide budget in bootstrap.rs (reviewed lines 1035–1094), or explicitly narrow the contract to helper threads and assess the changed behavior. N−1 shared helpers plus C uncounted callers permit C+N−1 evaluators (N=4, C=2 permits 5).
  • Reject overlapping writer paths using the regeneration .files manifests before applying patches in regenerate.yml (reviewed lines 123–132). Successful git apply does not establish disjoint writers: the existing demonstration shows two separated hunks in the same file both apply. Preserve binary-patch support and reuse that evidence.
  • Restore the shared environment guard around transferred-export identity/git/tool-version/replay work in export_custody.rs (reviewed lines 381–393). The transferred take path bypasses the guarded production_export path. Place the guard after waiting and environment-independent digest work; avoid holding it across the long wait or recursive fallback. This is a source-reachable interaction with exclusive PATH-sentinel tests, not an observed CI race.
  • Record the already-performed freshness plants, commands, observed refusals, restoration and scope in VERIFICATION.md. Reuse the existing owner evidence; no new plant or unrelated RP-14 runtime is requested.

Next owner checkpoint: identify the repair head or concrete blocker for these four items. Keep the changes bounded; coordinate any combined repair with the existing #405 forward lane. Reuse valid receipts and demonstrations, then qualify the final resulting head under the normal acceptance contract. No repeat of the completed #483 gate, competing implementation, blanket product regeneration or weakened check is requested. Close this issue with the actual merged repair PR and final-head/merged-tree evidence. Broad release and feature parents remain open.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions