Skip to content

Reject escaped-equivalent duplicate JSON keys before parsing #475

Closed

Description

@afflom

SPEC §21.7 forbids duplicate JSON object keys. The duplicate-key precheck compares raw escaped key spellings before serde_json decodes them, so {"a":1,"\u0061":2} can bypass the precheck and lose the first member when decoded keys collide.

Source review confirms the vulnerable canonical_json.rs blob 7d26a889052ca416b468946f7113f157de367877 is shared by main71def and current release/v0.4 bc71b33. This is source-confirmed; no additional runtime result is claimed here.

Existing implementation owner: @maurathat in #473 (head0179cc8f). This issue tracks that PR's release delivery; no competing implementation is requested.

Done when:

  • Duplicate detection compares decoded keys within each object, rejecting escaped-equivalent duplicates while allowing equal keys in distinct objects.
  • The existing AR-11 cases in fix(canonical-json): compare duplicate keys after escape decoding #473 cover direct and nested escaped collisions and the distinct-object case; preserve valid existing evidence.
  • The fix is delivered on the current release branch with the required changelog and reviewed final-head acceptance, followed by actual merged-tree equality and an explicit closure link.
  • Preserve required forward history into v0.5 through its existing owner.

This narrowly fixes canonical JSON input validation. It does not close the broader self-hosted standard-library work in #276.

Activity

  1. maurathat commented on Nov 11, 2026

    @maurathat
    Collaborator

    Done in #473: the PR now targets release/v0.4 (two commits on 7eb8162, the fix cherry-picked unchanged from the reviewed head 0179cc8 plus the changelog entry), links this issue, and keeps the escaped reproducer {"a":1,"\u0061":2}. CI on the new head will be the first full run.

  2. afflom commented on Nov 14, 2026

    @afflom
    MemberAuthor

    Release landing is recorded through #520, externally merged as f309afb. Its actual tree8aca516fe7732d22a31709f6924c0897c6ab354b equals reviewed head8d52665. The retained decoded-key comparison, direct/nested collision and distinct-object assertions, and changelog remain credited; no parser implementation or checks were repeated.

    This issue stays open pending final acceptance. Exact-head full run43555638296 attempt1 currently has65 successful jobs/732 successful steps and four queued Intel conformance jobs (lower/validate/moves/print). Same-run honesty and exact reproducibility43555638286 passed, but they do not substitute for the missing jobs or final checkout/tree binding. The later actual#533 merge6b1 has a different tree and is not blanket-qualified by this evidence.

    Existing qualification/forward owners retain completion of the already-running gate, actual tested-tree acceptance and required actual history into v0.5. Once the full issue criteria are satisfied, close explicitly with the merged#520 link. Broad#276 remains open. Receipt issue475-final-acceptance-20261114/receipt.json; no new gate, retry, producer or CI control requested.

  3. afflom commented on Nov 16, 2026

    @afflom
    MemberAuthor

    Explicit closure evidence for the narrow decoded-key fix: delivered through merged #520, actual f309afb, whose tree 8aca516f equals reviewed head 8d52665. The retained AR-11 direct/nested escaped-collision and distinct-object assertions, decoded-key comparison and changelog remain credited without repeating their implementation or tests.

    The original #520 gate ended with 67 successful jobs, two cancellations and one failure; it is not treated as passing. Later qualification comes from the already audited #551 gate 43709771141 attempt 2 (72 jobs/838 steps successful), and exact fa271 push gate 43744252595 attempt 1 (72 jobs/838 steps successful), at tree 0af41e38. #520 is in that release history. #556 carried that tree unchanged to main as a74b1f9. These are separate completed runs, not an aggregate assembled from failures.

    The external closure can remain in place for this scoped v0.4/main delivery. Required forward history remains with the existing owner under #404: current v0.5 7da6e93 lacks f309 ancestry and its selected parser source still compares raw escaped keys. Preserve that obligation; do not duplicate the fix. #276 and the broader audit/release parents remain open. This parser-fix credit does not lift #431/old TC-03 STOP or certify the affected release as a whole.

    Receipt: /workspace/work/issue475-external-closure-disposition-20261116-v2.json; SHA256 95d08129676f31bf6e400d14cabdf65fc347f5687e90f94bf0dbbe849e230daa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions