Skip to content

Sealed workspace fixes: undefined fields, gallery pictures, tests that read past the seal - #241

Open
humuhumu33 wants to merge 1 commit into
mainfrom
workspace-fixes
Open

humuhumu33 wants to merge 1 commit into
mainfrom
workspace-fixes

Conversation

@humuhumu33

Copy link
Copy Markdown
Contributor

Follow-up to #238.

  • Undefined fields: the codec now restores keys whose value is undefined. JSON dropped them, and modules that check record shapes exactly refused the record.
  • Gallery pictures: gallery: refs stay plain. A gallery picture is a Blob, which can't be read inside a transaction to be sealed, and the card is made to be published anyway. Before this, publishing a gallery card lost its picture.
  • Settings test: its fault injection keyed on the stored value, which is now sealed, so it never fired. It now keys on store and key.
  • Gallery test: it read through the plain handle and saw sealed bytes; it now uses workspace().

Still being worked on here: durable_build_work_browser and kernel_owner_readiness_browser, and the live-edit timing (one edit at 50.7 ms against a 33 ms budget) that sealing costs.

🤖 Generated with Claude Code

…, and two tests that read past the seal

A record kept a key whose value is undefined, and modules check record shapes
exactly: the codec now restores it. A gallery card's picture is a Blob, which cannot
be read inside a transaction to be sealed, and the card is made to be published, so
gallery refs stay plain. The settings fault injection keyed on the stored value,
which is now sealed; it keys on the store and key. The gallery test read through
the plain handle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant