Repository navigation
Sealed workspace fixes: undefined fields, gallery pictures, tests that read past the seal - #241
Open
humuhumu33 wants to merge 1 commit into
Open
humuhumu33 wants to merge 1 commit into
humuhumu33 wants to merge 1 commit into
Conversation
…, and two tests that read past the seal A record kept a key whose value is undefined, and modules check record shapes exactly: the codec now restores it. A gallery card's picture is a Blob, which cannot be read inside a transaction to be sealed, and the card is made to be published, so gallery refs stay plain. The settings fault injection keyed on the stored value, which is now sealed; it keys on the store and key. The gallery test read through the plain handle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #238.
undefined. JSON dropped them, and modules that check record shapes exactly refused the record.gallery:refs stay plain. A gallery picture is aBlob, which can't be read inside a transaction to be sealed, and the card is made to be published anyway. Before this, publishing a gallery card lost its picture.workspace().Still being worked on here:
durable_build_work_browserandkernel_owner_readiness_browser, and the live-edit timing (one edit at 50.7 ms against a 33 ms budget) that sealing costs.🤖 Generated with Claude Code