Repository navigation
Retire hosted source permission (FA-83): nothing sends source any more - #232
Merged
Merged
Conversation
Since #230 a stateful app is read, checked and proved in the tab, so no shell code transfers source to a hosted service. The permission boundary that guarded those transfers is deleted with its dialog, its unit and browser gates, its conformance test and feature suite, the CSS for its "Active" request pill, and its entries in the register, the Features and FoundrySpecification modules and product.json. The Versions and preview feature now says a preview sends no source anywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LdusN9UGDiUFDM7bZ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Asa3LdusN9UGDiUFDM7bZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#230 moved the reading, checking and proving of stateful apps into the tab. Since then, no shell code sends source to a hosted service. This PR retires the permission boundary that guarded those transfers.
Deleted:
shell/hosted-source-permission.mjs(the dialog and the transport guard)studio.ymlcrates/conformance/tests/hosted_source_permission.rsfeatures/suites/hosted-source-permission.featureModel:
model/ids.tomlandCONFORMANCE.md.testFA83,HostedSourcePermissionErrorandhostedSourcePermissionBoundaryare removed from the Features and FoundrySpecification modules, and fromproduct.json.Tests and docs:
shell_ui,approval_queueandbuild_source_browserno longer list the deleted module. The phrase-check test, which only the hosted gate fed, is gone.backlog_workflowspins one browser command fewer.studio/VERIFICATION.mdis removed, and the Proof row now describes in-tab proving.Checks
studio/tools/*.test.mjspasses, excepttelemetry, which fails only on the untracked local bundle.live_components, which needs esbuild, and that isn't installed here.build_source_browserpasses.Generated by Claude Code