feat(variants): ship Walking's own designer icon - #281
Merged
Conversation
Walking has so far reused Hiking's icons via icons: "target". The designer's walking-figure icon (right-aligned cut, chosen over a centred alternative) now ships instead: the 40x40/25x25 artwork composited onto the standard 60x60/30x30 canvases in the same glyph band as the sibling activity icons. The manifest switches to the PNG-pair form of "icons", which routes make_variant.py through its Pillow conversion path, so the pack-variants job gains the pip install the workflow comment had reserved for this moment. Verified: the CI-shape pack (fake Hiking_1.4.0-rc2 artifact) produces a Walking_1.4.0-rc2.uapp byte-identical to the alias bench-installed and render-checked on a watch (sha256 565ad39d...).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Walking variant manifest now specifies separate normal and small icons and requires target version 1.4.0. The variant-packing CI job installs Pillow for PNG-to-ABGR2222 icon conversion. ChangesVariant icon packaging
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Walking's config leans on the sport/subSport parameterization the 1.4.x Hiking engine carries, so gate the alias on it rather than resolving against any Hiking at all. The packed field is the A.B.C u32, which cannot see pre-release suffixes: 1.4.0-rc builds count as 1.4.0 and satisfy the gate (the kernel compares target->version < minTargetVersion, AliasRules.cpp).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Walking stops borrowing Hiking's icons (
"icons": "target") and ships the designer's walking-figure icon — the right-aligned cut, chosen over a centred alternative after simulator comparison. It also gains a realmin_target_version.Examples/Apps/Variants/Walking/icon_60x60.png/icon_30x30.png: the 40x40/25x25 artwork composited onto the standard canvases, placed in the same glyph band as the sibling activity icons (big: y 10-50 like Hiking's; small: y 2-27), palette already the standard teal so ABGR2222 quantization matches the other apps.manifest.json:iconsswitches to the{"normal", "small"}PNG-pair formpack_variants.pyalready supports, andmin_target_versiongoes0.0.0→1.4.0— Walking's config relies on the 1.4.x Hiking engine's sport parameterization, so the alias should not resolve against an older Hiking. Note the packed field is the A.B.C u32: pre-release suffixes are not representable, so1.4.0-rc*builds count as1.4.0and satisfy the gate.apps-ci.yml: thepack-variantsjob installs Pillow — the PNG conversion path inmake_variant.pyneeds it, and the workflow comment had explicitly reserved this install for the first custom-icon variant.Verification
--built-appswith aHiking_1.4.0-rc2artifact,--only Walking) reproduces the alias installed and render-verified on a watch running 1.4.0-rc2 — byte-identical except the twominTargetVersionbytes and the trailing CRC (the icon-only build hashed565ad39d8c45…, matching the on-watch file exactly). Launcher icon, adjacent-row small icon, and titles all checked on-device.Summary by CodeRabbit
New Features
Compatibility