[FIX] 도서 상세 조회 시 미등록 상태를 UNREGISTERED로 반환#288
Conversation
|
Warning Review limit reached
More reviews will be available in 51 minutes and 9 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough이 PR은 도서 상세 조회 시 서재에 미등록된 도서의 Changes미등록 도서 readingStatus 응답값 표준화
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/app/nook/controller/book/BookControllerTest.java (1)
118-118: ⚡ Quick win상세조회 응답의
readingStatus문서 스키마를 required로 고정해 주세요.상세조회 계약을
UNREGISTERED포함 고정값으로 표준화했으니, REST Docs에서도.optional()을 제거해 계약 회귀를 더 강하게 잡는 편이 좋습니다.제안 diff
- fieldWithPath("result.readingStatus").description("독서 상태 (서재에 없으면 UNREGISTERED)").optional() + fieldWithPath("result.readingStatus").description("독서 상태 (서재에 없으면 UNREGISTERED)")- fieldWithPath("result.readingStatus").description("독서 상태").optional() + fieldWithPath("result.readingStatus").description("독서 상태")Also applies to: 195-195
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/app/nook/controller/book/BookControllerTest.java` at line 118, Remove the .optional() qualifier from the REST Docs field descriptor for readingStatus so the detailed view schema is required; locate the fieldWithPath("result.readingStatus") usages in BookControllerTest (both occurrences around the detailed-view test) and delete the .optional() call so the descriptor is a required fieldWithPath(...).description(...).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/test/java/app/nook/controller/book/BookControllerTest.java`:
- Line 118: Remove the .optional() qualifier from the REST Docs field descriptor
for readingStatus so the detailed view schema is required; locate the
fieldWithPath("result.readingStatus") usages in BookControllerTest (both
occurrences around the detailed-view test) and delete the .optional() call so
the descriptor is a required fieldWithPath(...).description(...).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: abbde2c0-7127-4c66-b0f7-050a92056dd2
📒 Files selected for processing (4)
src/main/java/app/nook/book/converter/BookConverter.javasrc/main/java/app/nook/book/dto/BookResponseDto.javasrc/test/java/app/nook/book/service/BookServiceTest.javasrc/test/java/app/nook/controller/book/BookControllerTest.java
|
2 participants
📄 작업 내용 요약
readingStatus타입을ReadingStatusResponse로 변경readingStatus를UNREGISTERED로 반환하도록 수정📎 Issue 번호
✅ 작업 목록
📝 기타 참고사항