Refactor the internal DMPlex creation routines to support only a kinetic mesh formed of triangular cells. Fix #45 - #48
Merged
Conversation
…tic mesh formed of triangular cells. This simplifies the VantageDataTransfer class implementation.
mrhardman
merged commit Sep 30, 2026
2cc27c6
into
VANTAGE-Reactions-Coupling/dmplex-features
5 of 6 checks passed
mrhardman
deleted the
VANTAGE-Reactions-Coupling/dmplex-features-tri-only-mesh
branch
September 30, 2026 12:06
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the internal DMPlex creation routines to support only a kinetic mesh formed of triangular cells. This simplifies the VantageDataTransfer class implementation, and addresses the bug described in #45.
Purpose
This PR implements the triangular cell DMPlex as the only supported DMPlex mesh for VANTAGE. This is a simplification over the implementation currently in #44, where both a quad mesh (internally generated) and a triangular mesh (externally supplied) are supported.
Change Summary
use_cxx_ivertex=falsefunctionality is removed).bout_mesh->get().VantageDataTransfer::transfer_vector_to_kinetic_meshto ensure data is transferred to the output vector.Validation
The existing automatic tests were run in serial, jobs were run in parallel to check mass conservation.
AI Assistance
A LLM was consulted in designing these changes. No agentic LLM was used.
Documentation
No documentation besides comments.
Review Notes
@will-saunders-ukaea please comment on whether or not this addresses #45. A separate PR will separate the MPI decomposition #47.