Repository navigation
[MA-732] Parking Card - Remove Unnecessary Nesting - #2396
Open
minnykim06 wants to merge 2 commits into
Open
minnykim06 wants to merge 2 commits into
minnykim06 wants to merge 2 commits into
Conversation
Some dining locations from the API have no lat/lon. populateDistances now skips them instead of crashing on a null check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the Neighborhoods / Parking Structures drill-down with a single flat, alphabetical list of every structure and lot, each with an on/off switch. Switches use the existing toggleLot selection logic and the max-lots limit. Loading, error and empty states are kept. Remove the now-unused nested views, their routes and titles, and the provider helpers only they used. Add widget tests for the new view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
klortiz13
requested changes
Nov 13, 2026
klortiz13
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this! It looks soo much better.
Regarding performance, it takes a long time to load when I toggle a switch on or off. You need to find a way to maybe have the user toggle all they want, and when they go back to the home screen, the parking card just loads to reflect that (instead of loading on every toggle).
Let me know if you have any questions! Good job so far!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the nested parking selection UI (Neighborhoods / Parking Structures drill-down) with a single flat, alphabetical list of every parking structure and lot, each with an on/off switch. Also includes a separate fix for a dining crash that prevented the app from launching.
Changelog
Test Plan
flutter test test/ui/parking/manage_parking_view_test.dart: all 4 tests pass (flat sorted list, toggling via switch and row, 10-lot limit alert, loading/error/empty states).dart formatandflutter analyze: no new warnings in changed files.https://ucsdcloud.sharepoint.com/:x:/r/sites/WorkplaceTechnologyServices-CampusMobileBuilds/_layouts/15/Doc.aspx?sourcedoc=%7Bfe2497c3-e05a-4f4c-9174-c771a2619f58%7D&action=edit&wdPreviousSession=0035191d-b838-1423-8410-5ae77e584a74