Skip to content

[MA-732] Parking Card - Remove Unnecessary Nesting - #2396

Open
minnykim06 wants to merge 2 commits into
experimentalfrom
Parking-Card-Remove-Unnecessary-Nesting-minnykim06
Open

minnykim06 wants to merge 2 commits into
experimentalfrom
Parking-Card-Remove-Unnecessary-Nesting-minnykim06

Conversation

@minnykim06

@minnykim06 minnykim06 commented Nov 9, 2026 •

Copy link
Copy Markdown

Summary

Replaces the nested parking selection UI (Neighborhoods / Parking Structures drill-down) with a single flat, alphabetical list of every parking structure and lot, each with an on/off switch. Also includes a separate fix for a dining crash that prevented the app from launching.

Changelog

  1. [General] [Change] - Replace nested parking selection with a flat, alphabetical list of all structures and lots with on/off switches
  2. [General] [Remove] - Remove unused Neighborhoods, Neighborhood Lots, and Parking Structures views, their routes, and related provider helpers
  3. [General] [Fix] - Fix app crash on launch when a dining location has no coordinates
  4. [Internal] [Add] - Add widget tests for the parking selection view

Test Plan

  1. Ran flutter test test/ui/parking/manage_parking_view_test.dart: all 4 tests pass (flat sorted list, toggling via switch and row, 10-lot limit alert, loading/error/empty states).
  2. Ran dart format and flutter analyze: no new warnings in changed files.
  3. Launched the app on an Android emulator (QA environment) and confirmed it opens without the red "Null check operator" error screen.
  4. On the Parking card, tapped Manage Lots and confirmed all locations appear in one alphabetical list with switches.
  5. Turned lots on and off and confirmed the parking card updates and the choices stay saved after reopening the screen.
  6. Tried selecting more than 10 lots and confirmed the limit alert appears.

https://ucsdcloud.sharepoint.com/:x:/r/sites/WorkplaceTechnologyServices-CampusMobileBuilds/_layouts/15/Doc.aspx?sourcedoc=%7Bfe2497c3-e05a-4f4c-9174-c771a2619f58%7D&action=edit&wdPreviousSession=0035191d-b838-1423-8410-5ae77e584a74

minnykim06 and others added 2 commits November 9, 2026 15:12
Some dining locations from the API have no lat/lon. populateDistances
now skips them instead of crashing on a null check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the Neighborhoods / Parking Structures drill-down with a single
flat, alphabetical list of every structure and lot, each with an on/off
switch. Switches use the existing toggleLot selection logic and the
max-lots limit. Loading, error and empty states are kept.

Remove the now-unused nested views, their routes and titles, and the
provider helpers only they used. Add widget tests for the new view.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@minnykim06 minnykim06 self-assigned this Nov 9, 2026

@klortiz13 klortiz13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! It looks soo much better.

Regarding performance, it takes a long time to load when I toggle a switch on or off. You need to find a way to maybe have the user toggle all they want, and when they go back to the home screen, the parking card just loads to reflect that (instead of loading on every toggle).

Let me know if you have any questions! Good job so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants