Feat/aaronrhim/hmi gnss - #198
Open
aaronrhim wants to merge 6 commits into
Open
Conversation
aaronrhim
commented
Aug 8, 2026
aaronrhim
commented
Contributor
- good good
Tagging only ever worked at the rover's current fix, so a target radioed in by the judges or read off another map had nowhere to go. /tag_point now takes use_manual + manual_lat/manual_lon: those skip the fix (and its staleness check) and save the given coordinate, marked source: manual, so the report map and POI CSV pick them up with no exporter change. The HMI's GNSS Mission module grows a lat/lon/label/category row — "51.45, -112.72" can be pasted whole into the lat box — and the CLI grows tag <category> --at LAT LON. Manual points draw as diamonds, not circles, so a planned target never reads as somewhere the rover has been, and they survive a new mission's map reset (they are targets for the run about to start); "Clear points" drops them. A point the manager can't record is still plotted, with the status line saying it wasn't saved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MVnkniQw4JnNdMUwT9EZej
…at/aaronrhim/hmi_gnss # Conflicts: # src/rover_hmi_core/include/rover_hmi_core/tasks/gnss_map_widget.h
Clean-up pass over the hmi_gnss branch: remove the manual point-adding feature (typed lat/lon entry, pick-on-map, diamond markers, fetch-tiles, multi-site tile compositing) from the HMI map/module, TagPoint.srv, mission_manager, tag CLI, and docs. Kept: - /ip_camera/camera/image_raw topic rename (launch + PTZ module) - report export: mission.geojson (RFC 7946) + poi.csv alongside route_map.png, atomic writes, robust export service error reporting - fix freshness measured by arrival age (GNSS drivers stamp with GPS time or zero, which can't be compared to the node clock) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U4wRZetdjV4dSTdBeRtnm5
A separate module + test file was overhead for ~20 lines of JSON shaping: fold write_geojson into exporter.py (waypoints as Points, the track as a LineString), covered by the existing exporter test. Segment slicing in the geojson is dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U4wRZetdjV4dSTdBeRtnm5
aaronrhim
enabled auto-merge (squash)
August 8, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.