Cameron/camera enhance - #188
Open
Luxaris wants to merge 2 commits into
Open
Conversation
Author
|
The selector is intended as a prototype UI path, i think the long-term dashboard integration can publish the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Cameron-Basara as discussed, the ROI selector and enhancer.
it adds a prototype ROI selector workflow for camera zooming. The following were my changes:
camera_enhancerto accept dynamic ROI updates from/camera/roi_selectroi_selectornode that lets the user drag-select a region in an OpenCV windowsensor_msgs/RegionOfInterestroi_selectoras aros2 run rover_vision roi_selectorentry pointtest_files/used for ad hoc camera/viewer scripts