Skip to content

Cameron/camera enhance - #188

Open
Luxaris wants to merge 2 commits into
mainfrom
cameron/camera_enhance
Open

Cameron/camera enhance#188
Luxaris wants to merge 2 commits into
mainfrom
cameron/camera_enhance

Conversation

@Luxaris

@Luxaris Luxaris commented Aug 5, 2026

Copy link
Copy Markdown

@Cameron-Basara as discussed, the ROI selector and enhancer.

it adds a prototype ROI selector workflow for camera zooming. The following were my changes:

  • Extend camera_enhancer to accept dynamic ROI updates from /camera/roi_select
  • Add a new roi_selector node that lets the user drag-select a region in an OpenCV window
  • It publsiehs selected ROIs using sensor_msgs/RegionOfInterest
  • Keeps the existing hardcoded bottom-right zoom behavior as the fallback before any ROI is selected
  • Adds reset behavior via an all-zero ROI message
  • Registers roi_selector as a ros2 run rover_vision roi_selector entry point
  • Ignores local test_files/ used for ad hoc camera/viewer scripts

@Luxaris
Luxaris requested a review from Cameron-Basara August 5, 2026 22:33
@Luxaris Luxaris self-assigned this Aug 5, 2026
@Luxaris

Luxaris commented Aug 5, 2026

Copy link
Copy Markdown
Author

The selector is intended as a prototype UI path, i think the long-term dashboard integration can publish the same RegionOfInterest messages without changing camera_enhancer. So it should be modularizable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants