Consolidate leaderboard into one query-param page#91
Open
b006n97 wants to merge 1 commit into
Open
Conversation
Collapse the four prop-driven per-board routes into a single /leaderboard page that reads ?variant=&type= via useSearchParams and lets the user switch boards in-page. Legacy URLs (/leaderboard/jp, .../casual, /leaderboard/hk, ...) now redirect with the intended board carried in the query string, so existing links/bookmarks still land on the right selection. App.tsx changes are scoped to the leaderboard routes; games/create routing is migrated in later PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse the four prop-driven per-board routes into a single /leaderboard page that reads ?variant=&type= via useSearchParams and lets the user switch boards in-page. Legacy URLs (/leaderboard/jp, .../casual, /leaderboard/hk, ...) now redirect with the intended board carried in the query string, so existing links/bookmarks still land on the right selection.
App.tsx changes are scoped to the leaderboard routes; games/create routing is migrated in later PRs.