Decompose NavBar into a navbar/ module#88
Open
b006n97 wants to merge 1 commit into
Open
Conversation
Replace the 469-line monolithic common/NavBar.tsx with a focused module: - navbar/index.tsx: composition + shared AppBar shell - DesktopNav.tsx / MobileDrawer.tsx: the two responsive layouts - LogoIcon.tsx, navStyles.ts (shared sx + easing), navActive.ts (active-route helpers) WithNav.tsx now imports @/common/navbar. Behavior is preserved (same links, auth gating, active highlighting); styling is updated to the new theme. Depends only on the design-system foundation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the 469-line monolithic common/NavBar.tsx with a focused module:
WithNav.tsx now imports @/common/navbar. Behavior is preserved (same links, auth gating, active highlighting); styling is updated to the new theme. Depends only on the design-system foundation.