Skip to content

UI overhual#84

Closed
b006n97 wants to merge 14 commits into
mainfrom
ui-overhual
Closed

UI overhual#84
b006n97 wants to merge 14 commits into
mainfrom
ui-overhual

Conversation

@b006n97

@b006n97 b006n97 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

UI Overhaul

A comprehensive redesign of the frontend, introducing a new theme system, refreshed pages, and reusable design primitives.

Theme & Design System

  • New theme architecture (theme/tokens.ts, theme/index.ts) with scheme-aware palette tokens exposed as --mui-palette-* CSS variables that flip automatically between light and dark.
  • Light mode + selectable accent colors via a new AccentContext, persisting a runtime accent switch.
  • Added animations.ts and expanded theme/utils.ts helpers.
  • New DESIGN.md documenting the design language.

New Shared Components

  • Atoms: StatCard, IconBadge, SectionHeader.
  • Game primitives: GameSummaryCard, TransactionTypeSelector, StepSection, RoundRequirements, plus a shared placement.ts helper.
  • Statistics: PlacementDistributionBar, StatisticsSummary.

Redesigned Pages

  • Home with new hero artwork (hero.webp) and a substantially expanded landing page.
  • Record Game flow redesigned (CreateGame, TableDisplay, Footer, legacy JP/HK game tables).
  • Games & Logs refactored, new Games.tsx overview, refreshed LiveGames.
  • Leaderboard, Statistics, and Resources pages restyled.
  • Login / Register / Account pages reworked.

Navigation & Mobile

  • Major NavBar rework (~960 lines changed) with an improved mobile sidebar and broad mobile optimization.

Notes for reviewers

  • backend/prisma/schema.prisma shows a large diff but it's purely reformatting (4-space → 2-space indentation) — no schema changes.
  • Backend japaneseGame.service.ts / hongKongGame.service.ts changes are one line each.

@iForgot321 iForgot321 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy shit the new UI looks crazy good, few small comments on initial look. Haven't dug through the majority of the code yet though, some parts do look very bloated

Comment thread backend/prisma/schema.prisma
Comment thread package.json Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a package.json on the repository root, how is this being used?

Comment thread frontend/src/game/common/Footer.tsx Outdated
tabIndex={0}
aria-pressed={isSelected}
aria-label={`${wind ? `${windName(wind)} wind, ` : ""}${username}, score ${score.toLocaleString()}`}
sx={{

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS here might be a little too much

Comment thread frontend/src/game/common/Footer.tsx Outdated
Comment thread frontend/src/game/common/Footer.tsx Outdated
Comment thread frontend/src/game/common/Footer.tsx Outdated
Comment thread frontend/src/game/common/RoundRequirements.tsx
Comment thread frontend/src/statistics/PlacementHistoryGraph.tsx
Comment thread frontend/src/common/NavBar.tsx Outdated
sx={{
...frostedButtonBase,
"@media (hover: hover)": {
"&:hover": {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think always displaying the dot looks better than only on hover

@dennisgubc dennisgubc self-requested a review June 29, 2026 18:42
@dennisgubc

Copy link
Copy Markdown
Contributor

@b006n97 I will take a look at this PR once I have time this week. I will need to set up my local VM to actually inspect everything. May I ask @iForgot321 not to merge this before at least 2 approvals (including the one from me) from reviewers. During this time @b006n97 please read your code thoroughly and make sure you understand every single line.

@dennisgubc dennisgubc added the enhancement New feature or request label Jun 29, 2026
@b006n97

b006n97 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

PR rebased into #97, a more iterative 12-PR review stack. Review the
small, ordered slices below (bottom-up) instead, and merge when all other slices are approved.
@dennisgubc @iForgot321 @ZihaoHuang2017

@b006n97 b006n97 closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants