Skip to content

feat: retire the agent-ok and by-agent label mechanism - #3

Merged
TzuH-Hsu merged 1 commit into
mainfrom
chore/retire-agent-labels
Sep 7, 2026
Merged

TzuH-Hsu merged 1 commit into
mainfrom
chore/retire-agent-labels

Conversation

@TzuH-Hsu

@TzuH-Hsu TzuH-Hsu commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Retire the agent-ok (self-service work queue) and by-agent (audit-trail) labels: declaration in labels.yml, the labeler automation, the issue-form checkbox, and every doc and skill that told agents or humans to use them. Neither label had a consumer; provenance already lives in the Co-Authored-By commit trailer and the PR author account. Rationale and rejected alternatives in ADR-0007.

Cherry-picked from the template TzuH-Hsu/github-project-os#37 (bd8258d) and re-resolved against this repo's older template baseline: only the label retirement is applied, no other template drift is pulled in.

Retires agent-ok, by-agent — no successor.

Related issue

Template decision: TzuH-Hsu/github-project-os#36. No repo-local issue; this is a mechanical follow-through of that decision.

Validation

  • L0 static — markdownlint-cli2 on all changed .md, yaml-lint on labels.yml, issue-labeler.yml, and the three issue forms (all green; make lint needs markdownlint-cli2 installed globally, CI runs the full target)
  • L1 unit — no code touched
  • L2 integration — n/a
  • L3 e2e / preview — n/a

Risk / rollback

RISK: L0 `make lint` run piecewise, not via the Makefile — CI is the authoritative gate
Rollback: revert this PR and re-run scripts/bootstrap.sh to restore the two labels

Follow-up after merge (owner runs): gh label delete agent-ok --yes && gh label delete by-agent --yes. Do not use bootstrap.sh --prune.

Checklist

Before merging:

  • Conventional Commit PR title (<type>: <description>)
  • Linked issue using "Closes #N" — none local, see Related issue
  • No secrets, no *.local.md files committed
  • Documentation updated where affected

Both labels were write-only: agent-ok had one producer (the issue labeler
copying a form checkbox) and no consumer; by-agent had neither. Nothing
gated, routed, or recorded on them, and provenance already lives in the
Co-Authored-By trailer and the PR author account.

- Drop both entries from labels.yml, the Agent eligibility checkbox from
  the three issue forms, and the agent-ok sync + isFormManaged clause from
  issue-labeler.yml (priority/area/type sync unchanged). This also removes
  the silent stripping of a hand-added agent-ok on issue edit.
- AGENTS.md: start-work rule is explicit human assignment; provenance is
  the commit trailer. README, design principle 7, PROJECT_FIELDS,
  project-views (Agent queue view removed), bootstrap Ready description
  and view count updated to match.
- Skills agent-workflow, pr-authoring, issue-writing, anti-patterns,
  code-review reworded; no reference to either label remains.
- ADR-0007 records the decision and rejected alternatives; ADR-0003 left
  untouched as history.

Retires agent-ok, by-agent — no successor.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

Cherry-picked from the template TzuH-Hsu/github-project-os#37 and re-resolved
against this repo's older template baseline: only the label retirement is
applied, no other template drift is pulled in.
(cherry picked from commit bd8258db4eb28f04516b0fbd7fa742fdccb9fbe8)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T01:18:56.500024Z e7deae9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7deae94e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

3. **Provenance is the commit trailer and the PR author.** No label, and no attribution line in the PR body — the body carries validation claims, not authorship.
4. **ADR-0003 is not edited.** Its line listing "agent eligibility" among label-owned facts is historical; this ADR supersedes that clause only.

Principle 7 in `docs/template/design-principles.md` ("AI agents are first-class, humans stay in control") survives reworded: agents share the same issue, PR, and validation contract as humans and load the same skills; humans decide what agents work on and gate merges, releases, and destructive operations.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the reference to the absent design-principles file

In the reviewed commit tree, a repo-wide file search and git cat-file check confirm that docs/template/design-principles.md does not exist. Readers therefore cannot inspect the principle this paragraph claims to reword, and the code-formatted path is not a Markdown link, so the link checker will not detect the problem; remove this upstream-only reference or point to an existing local source.

AGENTS.md reference: AGENTS.md:L82-L84

Useful? React with 👍 / 👎.

---
name: agent-workflow
description: Use when an AI agent picks up, executes, or hands off repository work — queue, boundaries, audit.
description: Use when an AI agent picks up, executes, or hands off repository work — assignment, boundaries, honest reporting.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the second skill index with the new description

When a reader uses skills/README.md to decide which skill to load, its agent-workflow row still advertises “queue, boundaries, audit,” while this changed frontmatter and the new policy replace the queue with explicit assignment. Update that index row alongside this line so the repository no longer presents the retired queue model through one of its two skill catalogs.

AGENTS.md reference: AGENTS.md:L60-L62

Useful? React with 👍 / 👎.

1. **Remove both labels with no successor.** They leave `.github/labels.yml`, the labeler, the issue forms, `PROJECT_FIELDS.md`, and every doc and skill that referenced them. The "Agent queue" view is dropped from `docs/setup/project-views.md`.
2. **The start-work rule is explicit human assignment.** An agent works an issue when a human assigns it or names it in the conversation. Project `Status` `Ready` means "scoped"; it no longer implies "claimable by agents".
3. **Provenance is the commit trailer and the PR author.** No label, and no attribution line in the PR body — the body carries validation claims, not authorship.
4. **ADR-0003 is not edited.** Its line listing "agent eligibility" among label-owned facts is historical; this ADR supersedes that clause only.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a supersession marker to ADR-0003

When a future reader opens ADR-0003 directly, it remains Accepted and still states that labels own agent eligibility, with no pointer to this new decision. Saying only here that the clause is historical leaves two accepted ADRs giving conflicting guidance; update ADR-0003's status or add a backward supersession note so readers of the older record discover this replacement.

Useful? React with 👍 / 👎.

@TzuH-Hsu
TzuH-Hsu merged commit 83174d7 into main Sep 7, 2026
1 check passed
@TzuH-Hsu
TzuH-Hsu deleted the chore/retire-agent-labels branch September 7, 2026 01:24
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
TzuH-Hsu pushed a commit that referenced this pull request Sep 15, 2026
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2026-09-07)


### Features

* retire the agent-ok and by-agent label mechanism
([#3](#3))
([83174d7](83174d7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@TzuH-Hsu TzuH-Hsu mentioned this pull request Sep 15, 2026
TzuH-Hsu added a commit that referenced this pull request Sep 15, 2026
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2026-09-07)


### Features

* retire the agent-ok and by-agent label mechanism
([#3](#3))
([83174d7](83174d7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant