Skip to content

feat: retire the agent-ok and by-agent label mechanism - #3

Merged
TzuH-Hsu merged 1 commit into
mainfrom
chore/retire-agent-labels
Sep 7, 2026
Merged

feat: retire the agent-ok and by-agent label mechanism#3
TzuH-Hsu merged 1 commit into
mainfrom
chore/retire-agent-labels

Conversation

@TzuH-Hsu

@TzuH-Hsu TzuH-Hsu commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Retire the agent-ok (self-service work queue) and by-agent (audit-trail) labels: declaration in labels.yml, the labeler automation, the issue-form checkbox, and every doc and skill that told agents or humans to use them. Neither label had a consumer; provenance already lives in the Co-Authored-By commit trailer and the PR author account. Rationale and rejected alternatives in ADR-0007.

Cherry-picked from the template TzuH-Hsu/github-project-os#37 (bd8258d) and re-resolved against this repo's older template baseline: only the label retirement is applied, no other template drift is pulled in.

Retires agent-ok, by-agent — no successor.

Related issue

Template decision: TzuH-Hsu/github-project-os#36. No repo-local issue; this is a mechanical follow-through of that decision.

Validation

  • L0 static — markdownlint-cli2 on all changed .md, yaml-lint on labels.yml, issue-labeler.yml, and the three issue forms (all green; make lint needs markdownlint-cli2 installed globally, CI runs the full target)
  • L1 unit — no code touched
  • L2 integration — n/a
  • L3 e2e / preview — n/a

Risk / rollback

RISK: L0 `make lint` run piecewise, not via the Makefile — CI is the authoritative gate
Rollback: revert this PR and re-run scripts/bootstrap.sh to restore the two labels

Follow-up after merge (owner runs): gh label delete agent-ok --yes && gh label delete by-agent --yes. Do not use bootstrap.sh --prune.

Checklist

Before merging:

  • Conventional Commit PR title (<type>: <description>)
  • Linked issue using "Closes #N" — none local, see Related issue
  • No secrets, no *.local.md files committed
  • Documentation updated where affected

Both labels were write-only: agent-ok had one producer (the issue labeler
copying a form checkbox) and no consumer; by-agent had neither. Nothing
gated, routed, or recorded on them, and provenance already lives in the
Co-Authored-By trailer and the PR author account.

- Drop both entries from labels.yml, the Agent eligibility checkbox from
  the three issue forms, and the agent-ok sync + isFormManaged clause from
  issue-labeler.yml (priority/area/type sync unchanged). This also removes
  the silent stripping of a hand-added agent-ok on issue edit.
- AGENTS.md: start-work rule is explicit human assignment; provenance is
  the commit trailer. README, design principle 7, PROJECT_FIELDS,
  project-views (Agent queue view removed), bootstrap Ready description
  and view count updated to match.
- Skills agent-workflow, pr-authoring, issue-writing, anti-patterns,
  code-review reworded; no reference to either label remains.
- ADR-0007 records the decision and rejected alternatives; ADR-0003 left
  untouched as history.

Retires agent-ok, by-agent — no successor.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

Cherry-picked from the template TzuH-Hsu/github-project-os#37 and re-resolved
against this repo's older template baseline: only the label retirement is
applied, no other template drift is pulled in.
(cherry picked from commit bd8258db4eb28f04516b0fbd7fa742fdccb9fbe8)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T01:19:19.720780Z 0b8e874 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b8e874d49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Consequences

- Six downstream repositories carry the labels. They pick up the change by cherry-picking the template commit and then deleting the two labels with `gh label delete`. `scripts/bootstrap.sh --prune` is **not** the sync path: it deletes every label absent from `labels.yml`, including ones a downstream repo added by hand.
- Existing Projects keep the old `Ready` option description ("agent-ok issues are self-service here") until bootstrap is re-run against them; the text is cosmetic.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the manual migration for existing Projects

For any existing Project whose Status option names already match the target set, status_options_decision returns target-skip at scripts/bootstrap.sh:498-505, so phase_project never runs the mutation that updates descriptions. Rerunning bootstrap therefore leaves the explicit agent-ok self-service wording in place indefinitely; document the required manual edit or implement a safe description-only migration instead of promising that a rerun removes it.

AGENTS.md reference: AGENTS.md:L55-L55

Useful? React with 👍 / 👎.

@TzuH-Hsu
TzuH-Hsu merged commit a248f07 into main Sep 7, 2026
1 check passed
@TzuH-Hsu
TzuH-Hsu deleted the chore/retire-agent-labels branch September 7, 2026 01:24
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant