Skip to content

fix: the labeler test no longer assumes area:ci exists in the repository's labels.yml #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TzuH-Hsu merged 2 commits into from
Sep 16, 2026
Merged

fix: the labeler test no longer assumes area:ci exists in the repository's labels.yml #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c05d14
fix: the labeler test no longer assumes area:ci exists in the reposit…
TzuH-Hsu Sep 16, 2026
8e49b61
fix: derive the undeclared sentinel instead of naming one
TzuH-Hsu Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions scripts/issue-labeler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,14 @@ test('run: an empty area set warns and applies nothing for Area', async () => {
assert.equal(warnings.length, 1);
});

test("this repository's labels.yml: the shipped starter set behaves as before", () => {
test("this repository's labels.yml: a declared area is applied, an undeclared one is not", () => {
// Must hold in any adopted repo, whatever the area names are — the
// template tells adopters to rename the starter set, so no name is assumed.
const areas = labeler.readAllowedAreas(path.join(__dirname, '..'));
assert.ok(areas.includes('area:ci'));
const r = changes('### Area\n\n- [x] area:ci — CI workflows and automation\n- [x] area:nope — n', [], areas);
assert.deepEqual(r.toAdd, ['area:ci']);
if (areas.length === 0) return; // an adopter may have dropped the family entirely
const first = areas[0];
let undeclared = 'area:undeclared';
while (areas.includes(undeclared)) undeclared += '-x';
const r = changes(`### Area\n\n- [x] ${first} — declared\n- [x] ${undeclared} — n`, [], areas);
assert.deepEqual(r.toAdd, [first]);
});