Skip to content

Task: land the Codex fixes to #71 that were pushed after the merge #73

Description

@TzuH-Hsu

Summary

PR #71 merged with its first commit only; the follow-up commit that answered Codex's two P2 findings was pushed after the branch was deleted and never reached main.

Subtype

docs — Documentation

Context

Codex found two problems in #71 and both were fixed in commit 5155034, but gh pr merge had already squashed d730499 (merged 2026-09-16T08:05:30Z, branch deleted three seconds later), so the push recreated a dead branch and the replies on the review threads describe a fix that is not on main.

What main still says:

  • skills/branch-and-commit/SKILL.md rule 3 offers "a behaviour-changing refactor" as an example of a hidden-type change that should ship via Release-As. A refactor that changes behaviour is a fix or a feat, not a refactor — the example teaches the wrong type, which is the very mistake the paragraph is about.
  • skills/release-management/SKILL.md rule 2 says the version bump is derived, never chosen, but the Release-As footer the same skill's pitfall recommends is a chosen version. The rule needs the exception stated, with its bound: X.Y.Z is always the current version plus one patch, and wanting more than a patch means the type was wrong (a hidden type also keeps the change out of the changelog).

The fix is the content of 5155034 re-applied on a branch from main. Docs only, hidden type, no release.

Acceptance criteria

  • skills/branch-and-commit/SKILL.md rule 3 no longer names a behaviour-changing refactor as a hidden-type example, and points at release-management rule 2 for the patch-only bound
  • skills/release-management/SKILL.md rule 2 states the Release-As exception and that X.Y.Z is the current version plus one patch; the pitfall refers to rule 2 instead of restating the recipe
  • make verify passes

Priority

p2 — Important, scheduled

Area

  • area:docs — Documentation and guides
  • area:skills — Skills knowledge modules
  • area:ci — CI workflows and automation
  • area:governance — Labels, templates, metadata contract, process

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:skillsSkills knowledge modulespriority:p2Important, scheduledtype:docsDocumentation subtype (native type stays Task)

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions