Add CalculateCyclesInWindow function#4
Merged
Conversation
Add CalculateCyclesInWindow to calculate the number of complete sleep cycles and remaining overflow duration within a given time window. Handles next-day wake times by adding 24h when to is not after from. Add tests covering buffer, overflow, next-day wake, midnight boundary, and same from/to edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds window-based cycle calculation to the core logic, returning both complete cycle count and remaining overflow duration.
Changes
internal/cycle/cycle.go_internal/cycle/cycle_test.goNotes
(int, time.Duration)— overflow is intentionally exposed for use by the output layer to indicate how far into a partial cycle the wake time falls