Fixed handleTutorial double invocation#73
Conversation
-Put handleTutorial invocation behind a check for the "mapDidLoad" event
|
Does this correspond to an open issue? What does putting handleTutorial behind mapDidLoad change or fix? |
This was something I encountered while working on animation cancelling. Since handleTutorial was being invoked twice (once on "mapDidLoad" and again on "levelDidLoad"), it would cause the cancellation to behave in unexpected ways. I'll add this to the initial comment, since this PR seems kind of random otherwise haha |
|
I know we did a review of animation cancelling and did some feedback on it. Is this PR still relevant in light of that review? |
It's hard to say. Depending on how we implement animation cancelling (even with the event based approach), this may still cause unintended behavior |
-Put handleTutorial invocation behind a check for the "mapDidLoad" event
Reasoning: While working on animation cancelling, this "double invocation" would cause unexpected behavior due to several duplicate async functions being called