Repository navigation
chore: resolve bottom 40 unused-import quality findings - #2451
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Logo rendering and feed components src/components/LogoV2/{AnimatedAsterisk,AnimatedClawd,Clawd,CondensedLogo,FeedColumn,feedConfigs}.tsx |
The Clawd renderers, animation components, feed components and builders, and condensed layout were deleted. |
Notices and upsell components src/components/LogoV2/{ChannelsNotice,EmergencyTip,GuestPassesUpsell,Opus1mMergeNotice,VoiceModeNotice}.tsx |
The channel and emergency notices, guest-pass upsell, and voice-mode and Opus merge notices were deleted. |
Logo composition removal src/components/LogoV2/LogoV2.tsx, src/components/Messages.tsx |
The LogoV2 component and its import in Messages were removed. |
Unused import cleanup
| Layer / File(s) | Summary |
|---|---|
Remove unused imports src/components/*.tsx, src/components/HelpV2/HelpV2.tsx, src/components/PromptInput/Notifications.tsx, src/components/StructuredDiff/Fallback.tsx, src/components/agents/..., src/components/design-system/..., src/components/diff/..., src/components/hooks/..., src/components/mcp/..., src/components/messages/..., src/components/permissions/... |
Unused React hooks, React, Fuse, and command imports were removed. No runtime logic changes are described for these edits. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Other
Possibly related PRs
- Twigpine/openclaude#2433: Removes unused React imports and a local binding in other files.
- Twigpine/openclaude#2440: Removes Fuse-based deep search from LogSelector; this change removes its remaining Fuse import.
- Twigpine/openclaude#2432: Removes unused imports from other files.
Suggested reviewers: devpedry, kevincodex1, gnanam1990
Merge Risk: 
9fd0f
-
No user-facing behavior change or merge-blocking risk is evidenced.
Pre-merge checks: 
-
Check name Status Explanation Resolution Risk Surface Disclosed The PR touches listed risk surfaces: MCP files, permission-request and computer-use approval components, and the deleted legacy ChannelsNotice, which contained MCP, plugin, and auth checks. The desc…Add a risk-surface note to the PR description or review. Name the permissions, MCP/plugin, and auth-related legacy paths; state that the edits are unused-import removals or disconnected-code deletion; and explicitly state whether they intro… -
Check name Status Explanation Title check The title is concise, scoped, and accurately describes the primary change: resolving the selected unused-import quality findings. It also covers the related cleanup of disconnected legacy logo files. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. No Hidden Policy Change No hidden policy change is introduced. The non-deletion edits remove import bindings only. In the base, Messages.tsximportedLogoV2, butLogoHeaderassignednulland renderedStatusNotices…Description check The description follows the repository template. It explains the changes, rationale, impact, affected surfaces, validation commands and results, focused tests, inapplicable checks, CI status, review s… Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 34 files.
Full details: No Hidden Policy Change
-
Explanation
No hidden policy change is introduced. The non-deletion edits remove import bindings only. In the base,
Messages.tsximportedLogoV2, butLogoHeaderassignednulland renderedStatusNoticesinstead (Messages.tsx:36, 63-71, 683-684); no live<LogoV2>call exists. The deleted LogoV2 files form a disconnected graph with no external references. Channel enforcement and permission gates remain insrc/services/mcp/channelNotification.tsanduseManageMCPConnections.ts, and live welcome, status, overage, and permission components remain. The diff does not change routing defaults, telemetry/network enforcement, trust boundaries, or permission policy.
Full details: Description check
-
Explanation
The description follows the repository template. It explains the changes, rationale, impact, affected surfaces, validation commands and results, focused tests, inapplicable checks, CI status, review status, and known limitations.
-
Full details: Risk Surface Disclosed
-
Explanation
The PR touches listed risk surfaces: MCP files, permission-request and computer-use approval components, and the deleted legacy
ChannelsNotice, which contained MCP, plugin, and auth checks. The description calls out generic component-import and legacy-logo changes, unchanged logic, and no local gate blockers, but it does not explicitly identify these sensitive surfaces or state whether they introduce a blocker. The current review has zero actionable findings and no risk-surface discussion.Resolution
Add a risk-surface note to the PR description or review. Name the permissions, MCP/plugin, and auth-related legacy paths; state that the edits are unused-import removals or disconnected-code deletion; and explicitly state whether they introduce a blocker. Also record any CI or review checks that remain pending.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
jatmn
marked this pull request as ready for review
October 27, 2026 14:56
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the bottom 40 open findings in the unused-local-variable Code Quality list, selected from the managed findings API's default descending order.
Remove 44 unused import bindings. Removing the unused
LogoV2import also exposes 12 unreachable legacy logo files to the required Knip gate; remove precisely that disconnected group. The former logo slot already rendersnull, and the live welcome screen, wordmark, status notices, and overage components remain.Managed Code Quality finding IDs:
33,35,36,37,41,43,46,48,49,51,50,52,54,55,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,81,82,84.Impact
Testing
9fd0f9a190adc2f0b2347ecc0d2239cba463efadwith Node 26.12.1 and Bun 1.4.4:bun install --frozen-lockfilebun run check:static— lint, any budget, CLI/SDK build and smoke, Knipbun run typecheck:fast— 3,310 filesbun run typecheck:type-tests— 11 filesnode bin/openclaude --versionNODE_DISABLE_COMPILE_CACHE=1 node bin/openclaude --versiongit fetch https://github.com/Twigpine/openclaude.git mainthenbun run security:pr-scan -- --base FETCH_HEAD --head HEADgit diff --checkbun run test src/components/agents/AgentsMenu.test.tsx src/components/ModelPicker.test.tsx src/components/ModelPicker.switchProfile.test.ts src/components/PromptInput/Notifications.effort.test.tsx src/components/HighlightedCode/Fallback.test.tsx src/components/LogSelector.resumeBranches.test.ts src/utils/markdown.test.ts src/utils/cliHighlight.test.ts src/utils/diff.test.ts src/components/LogoV2/WordmarkRow.test.tsx src/utils/statusNoticeDefinitions.safety.test.tsx src/__tests__/statusNoticeLocalModel.test.ts— 103 passed, 0 failed, 241 assertions.9fd0f9a190adc2f0b2347ecc0d2239cba463efadwith no inline findings. Both CodeQL analyses and the code-scanning result passed. The PR remains a draft for user/maintainer review.Notes
AGENTS.mdandCONTRIBUTING.md.