Prevent blank maintenance metadata from breaking monitoring - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
expectedDown:andexpectedDegraded:lines from the scheduled-maintenance templateRoot cause
The pinned Upptime monitor parses every colon-bearing metadata line with a split that assumes a non-empty value. The repository template instructed operators to leave optional impact values empty, so an active notice could crash the uptime workflow with
Cannot read properties of undefined (reading 'trim').Impact
Future maintenance notices can omit unused impact fields without breaking endpoint monitoring or leaving stale status data. Existing valid notices are unchanged.
Validation
ruby scripts/validate.rbgit diff --check