Skip to content

Prevent blank maintenance metadata from breaking monitoring - #6

Merged
masterfung merged 1 commit into
mainfrom
agent/fix-maintenance-metadata-template
Aug 17, 2026
Merged

masterfung merged 1 commit into
mainfrom
agent/fix-maintenance-metadata-template

Conversation

@masterfung

Copy link
Copy Markdown
Contributor

What changed

  • remove blank expectedDown: and expectedDegraded: lines from the scheduled-maintenance template
  • tell operators to add those fields only when they have a real component value
  • make repository validation reject blank impact metadata and retain safe examples

Root cause

The pinned Upptime monitor parses every colon-bearing metadata line with a split that assumes a non-empty value. The repository template instructed operators to leave optional impact values empty, so an active notice could crash the uptime workflow with Cannot read properties of undefined (reading 'trim').

Impact

Future maintenance notices can omit unused impact fields without breaking endpoint monitoring or leaving stale status data. Existing valid notices are unchanged.

Validation

  • ruby scripts/validate.rb
  • fresh live Uptime CI after correcting active metadata: passed
  • fresh static-site build/publish: passed
  • git diff --check

@masterfung
masterfung marked this pull request as ready for review August 17, 2026 07:03
@masterfung
masterfung merged commit a057c3a into main Aug 17, 2026
2 checks passed
@masterfung
masterfung deleted the agent/fix-maintenance-metadata-template branch August 17, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant