Skip to content

Comments

Added member cancellation reason header#26542

Open
weylandswart wants to merge 2 commits intomainfrom
member-cancelation-email-header
Open

Added member cancellation reason header#26542
weylandswart wants to merge 2 commits intomainfrom
member-cancelation-email-header

Conversation

@weylandswart
Copy link
Contributor

Ref https://linear.app/ghost/issue/DES-1296/cancellation-email-missing-styling-for-cancellation-reason

We had previously removed the cancellation reason heading. This adds it back.

Screenshot 2026-02-23 at 17 31 20

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Walkthrough

This change updates the paid subscription cancellation email template to include a "Cancellation reason:" label before the cancellation reason value when present. A corresponding test file was updated to verify the new label appears correctly in three assertions. The changes add clarity to the cancellation details section without altering the conditional visibility logic or template structure.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added member cancellation reason header' clearly and specifically describes the main change: restoring a cancellation reason header in the email template.
Description check ✅ Passed The description is directly related to the changeset, explaining that the cancellation reason heading was previously removed and this PR adds it back, with a reference to the Linear issue and visual proof.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch member-cancelation-email-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs (1)

19-23: Consider updating the preview text label for consistency.

The preview snippet (shown in email clients before opening) still reads Reason: while the email body now uses Cancellation reason:. The label mismatch is cosmetic but noticeable.

✏️ Suggested update
-  Reason: {{subscriptionData.cancellationReason}}
+  Cancellation reason: {{subscriptionData.cancellationReason}}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs`
around lines 19 - 23, The preview text label in the new-paid-cancellation
template is inconsistent: update the preview snippet that conditionally renders
subscriptionData.cancellationReason so the label matches the email body by
replacing "Reason:" with "Cancellation reason:" (locate the conditional block
using subscriptionData.cancellationReason in new-paid-cancellation.hbs and
change the preview label to "Cancellation reason:" to ensure consistency).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs`:
- Around line 19-23: The preview text label in the new-paid-cancellation
template is inconsistent: update the preview snippet that conditionally renders
subscriptionData.cancellationReason so the label matches the email body by
replacing "Reason:" with "Cancellation reason:" (locate the conditional block
using subscriptionData.cancellationReason in new-paid-cancellation.hbs and
change the preview label to "Cancellation reason:" to ensure consistency).

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3472e54 and 85fc37e.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs
  • ghost/core/test/unit/server/services/staff/staff-service.test.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant