Added the missing translations for de-CH#26517
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis pull request fills previously empty German (de-CH) translation strings. In 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghost/i18n/locales/de-CH/comments.json`:
- Line 22: Replace the informal imperative value for the JSON key "Contact
support" (currently "Kontaktiere den Support") with the formal/neutral phrasing
used elsewhere—use "Support kontaktieren" (matching the portal.json translation)
so the entry "Contact support" in comments.json uses the same formal register.
- Line 78: The translation for the key "You can't post comments in this
publication." uses "Artikel" which incorrectly means a single article; update
the German string in the JSON entry for the exact key "You can't post comments
in this publication." to use a correct term such as "Publikation" or "auf dieser
Seite" (e.g. "Sie können auf dieser Publikation keine Kommentare schreiben." or
"Sie können auf dieser Seite keine Kommentare schreiben.") so it accurately
conveys "publication" rather than "article."
In `@ghost/i18n/locales/de-CH/portal.json`:
- Around line 128-136: The translations use the informal imperative "Öffne ..."
and must be changed to the infinitive pattern used throughout the locale;
replace each "Öffne X" with "X öffnen" (e.g., change "Öffne Gmail" → "Gmail
öffnen", "Öffne Yahoo Mail" → "Yahoo Mail öffnen", and "Öffne E-Mail" → "E‑Mail
öffnen") and ensure consistent spelling/capitalization (use "E‑Mail" with a
hyphen) for the strings shown ("Open AOL Mail", "Open email", "Open Gmail",
"Open Hey", "Open iCloud Mail", "Open Mail.ru", "Open Outlook", "Open Proton
Mail", "Open Yahoo Mail").
- Around line 78-85: Two German translation strings are missing a trailing
period causing inconsistency; update the values for the keys "Failed to open
billing portal, please try again" (currently "Das Abrechnungsportal konnte nicht
geöffnet werden. Bitte versuchen Sie es erneut") and "Failed to send magic link
email" (currently "Anmelde-Link konnte nicht versendet werden") to include a
final period so they match the punctuation style used by nearby entries (e.g.,
end with ".").
Corrected the translation for various failure messages in German.
cathysarisky
left a comment
There was a problem hiding this comment.
Hi @ashikinoko ! Thank you for the translations, and I'm sorry you've waiting a bit for a human to respond. (This human is an unpaid volunteer, and sometimes it takes me a little while to make time.)
I've added two AI comments, which you can take or ignore, but here's a human comment that I'd really like answered:
You've removed a bunch of periods. (I think AI bots may have encouraged that.) Most of these strings show up in pop-up error messages. In English, the lack of a period works fine, but they'd also be fine with a period. [The English would also be more correct with two separate sentences, but we're not fixing that here.]
I don't know enough about Dutch German to know whether these periods are a problem and should be removed. Do you prefer these strings without the period, or did AI bots muddle the issue? I don't see any mention of it in the pull request itself.
So please:
-Don't change the periods on existing strings unless they're wrong.
-If they are wrong, please update the PR text to reflect those changes.
| "Enter your name": "Geben Sie Ihren Namen ein", | ||
| "Expertise": "Expertise", | ||
| "for more information.": "", | ||
| "for more information.": "für mehr Informationen.", |
There was a problem hiding this comment.
🤖 AI: For the string "for more information.", German normally capitalises the noun "Informationen" and often uses the phrase "weitere Informationen" in this context.?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
ashikinoko
left a comment
There was a problem hiding this comment.
Thanks for clarifying that. I have now readded a period at the end of the second sentence wherever there are two clearly separated sentences. That is more correct in German.
Thanks for clarifying that. I have now readded a period at the end of the second sentence wherever there are two clearly separated sentences. That is more correct in German. |
Added the missing translations for de-CH, especially the new "Open email" feature
Note
Low Risk
Low risk: only de-CH locale string additions/edits; main risk is minor UX issues from wording/punctuation changes.
Overview
Fills in previously empty
de-CHtranslation strings for the comments UI (e.g., disabled commenting/support links/admin view, linked-comment missing, posting restrictions).Completes
de-CHPortal translations, including the new “Open email” provider buttons plus billing portal/next payment/error messages, and normalizes a few strings (punctuation/wording) for consistency.Written by Cursor Bugbot for commit 3602252. This will update automatically on new commits. Configure here.