Repository navigation
Sample content: no Studio-only pointers in API-only projects - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
The sample content is shared by API-only, API + Studio and full-site projects. It sent API-only users to a
/studiothey don't have. The wording is now neutral: the welcome article says content can be edited "in the Studio or through the API" (no/studiolink), the draft tip and the contact page likewise, and the magazine footer (EN and FR) no longer names the Studio. Thestructure.tscomments say it also sets the id each singleton is opened and first created under.Left as is, on purpose: the magazine content describes a magazine site (home page, bylines). A headless project builds that site itself, so those sentences still hold.
Test: API-only magazine and conference seeds contain no
/studiolink or "in/dans Studio" (reverting any user-visible string, French included, fails it). Smoke workers-api-magazine, workers-full and node-full pass. Reviewed by Codex (clean) and an executing reviewer (comment accuracy and French-test gap fixed; the PUT singleton gap it found is Trokky/trokky#114).