Repository navigation
Node full-site: compile the server, start with node, typecheck it - #15
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12 and #13.
astro build && tsc -p tsconfig.json. Start:node dist/src/server.js(wastsx src/server.ts).../dist/server/entry.mjsimport failed tsc with TS7016, and its relative path is wrong from dist/src/).src/server.ts,trokky.config.ts), so a site endpoint usingimport.meta.envorastro:*doesn't break the server build;astro checkcovers the site.npm run devclears the compiled server).npm startwith NODE_ENV=production; build failures print tsc's output.Correction to #13: a Node full-site start was not actually dead on production installs today: tsx reaches production via astro → vite. The compiled start removes that dependency on an accident; the smoke's prune can't prove it, as the comment now says.
Smoke node-full, node-conference, node-api, node-studio, workers-full pass; 90 unit tests. Restoring the static import fails the build with TS7016. Reviewed by Codex (clean) and an executing reviewer (fixes applied: tsconfig include, README production steps, a vacuous test assertion, the cwd comment).