Repository navigation
Generated Workers projects typecheck; smoke checks it and runs npm start - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11 and #7. Merge after @trokky/trokky 3.6.2 is on npm: generated projects now require
^3.6.2(the R2 adapter fix), so CI cannot install until it is published.types: bare@cloudflare/workers-types(5.x dropped/2023-07-01).Parameters<typeof handle>[1]instead of theEnvglobal, which onlywrangler typescreates.tsc --noEmitfor every Workers case, with the diagnostics in the failure line; Node cases boot withnpm startandNODE_ENV=production.Locally against the packed 3.6.2 core: all six Workers compositions typecheck and build; node-api, node-studio, node-full and node-conference pass with npm start. Against npm 3.6.1 the new step fails with the TS2322 shown, as intended. Reviewed by Codex and an executing reviewer; both caught that typecheck diagnostics were dropped from the report, fixed. Pre-existing gaps the review surfaced are filed as #12 and #13.