Skip to content

Generated Workers projects typecheck; smoke checks it and runs npm start - #14

Merged
amenophis1er merged 1 commit into
mainfrom
fix/workers-types
Nov 15, 2026
Merged

amenophis1er merged 1 commit into
mainfrom
fix/workers-types

Conversation

@amenophis1er

Copy link
Copy Markdown
Contributor

Fixes #11 and #7. Merge after @trokky/trokky 3.6.2 is on npm: generated projects now require ^3.6.2 (the R2 adapter fix), so CI cannot install until it is published.

  • tsconfig types: bare @cloudflare/workers-types (5.x dropped /2023-07-01).
  • worker.ts: Parameters<typeof handle>[1] instead of the Env global, which only wrangler types creates.
  • Two type fixes in the magazine and conference site helpers.
  • Smoke: tsc --noEmit for every Workers case, with the diagnostics in the failure line; Node cases boot with npm start and NODE_ENV=production.

Locally against the packed 3.6.2 core: all six Workers compositions typecheck and build; node-api, node-studio, node-full and node-conference pass with npm start. Against npm 3.6.1 the new step fails with the TS2322 shown, as intended. Reviewed by Codex and an executing reviewer; both caught that typecheck diagnostics were dropped from the report, fixed. Pre-existing gaps the review surfaced are filed as #12 and #13.

@amenophis1er
amenophis1er merged commit aa5284b into main Nov 15, 2026
13 of 24 checks passed
@amenophis1er
amenophis1er deleted the fix/workers-types branch November 15, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated Workers projects do not typecheck: tsconfig names a removed workers-types entry point

1 participant