Skip to content

feat(nats): resolve NATS credentials from the environment so secrets stay out of walgit.toml #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 9 commits into from
Oct 27, 2026
Merged

feat(nats): resolve NATS credentials from the environment so secrets stay out of walgit.toml #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae202c9
feat(nats): resolve NATS credentials from the environment so secrets …
yordis Oct 27, 2026
9e106d3
fix(nats): keep a blank NATS variable from shadowing real credentials
yordis Oct 27, 2026
188f534
fix(nats): read the NATS_* variables the way the nats CLI does so one…
yordis Oct 27, 2026
2934afc
fix(nats): honour credentials in server URLs as the nats CLI does and…
yordis Oct 27, 2026
a7974fa
fix(nats): refuse a file: location that is not file:// instead of tru…
yordis Oct 27, 2026
ed72096
fix(events): keep credentials in NATS_URL out of debug output
yordis Oct 27, 2026
e9f047a
fix(events): require TLS when NATS_CA or a client certificate is set
yordis Oct 27, 2026
5b3e732
test(events): pick the rustls provider the way the walgit binary does
yordis Oct 27, 2026
abe048b
fix(events): refuse a lone NATS_CERT or NATS_KEY and hide passwords t…
yordis Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ parking_lot = "0.12"
moka = { version = "0.12", features = ["sync"] }
mimalloc = "0.1"
tempfile = "3"
nkeys = "0.4"
percent-encoding = "2"
flate2 = "1"
async-compression = { version = "0.4", features = ["tokio", "gzip"] }
pin-project-lite = "0.2"
Expand Down
16 changes: 16 additions & 0 deletions crates/walgit-nats/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,28 @@ license.workspace = true

[dependencies]
walgit-events.workspace = true
walgit-config.workspace = true
walgit-git.workspace = true
async-nats.workspace = true
nkeys.workspace = true
percent-encoding.workspace = true
anyhow.workspace = true
thiserror.workspace = true
bytes.workspace = true
tokio.workspace = true
tracing.workspace = true
serde_json.workspace = true
tempfile = { workspace = true, optional = true }

[features]
# `testing::start_nats`: a throwaway `nats-server -js` for integration tests.
testing = ["dep:tempfile"]

[dev-dependencies]
walgit-nats = { path = ".", features = ["testing"] }
tempfile.workspace = true
rcgen.workspace = true
rustls.workspace = true

[lints]
workspace = true
Loading