Repository navigation
Conversation
Delete the unminified and alternate builds of aos, bootstrap, glightbox and isotope from public/assets/vendor. The site only loads aos.js, bootstrap.bundle.min.js, glightbox.min.js and isotope.pkgd.min.js; the other copies were never referenced and were the source of every DeepScan finding (null checks, constant conditions, unused assignments) in third-party code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the unminified and alternate builds of aos, bootstrap, glightbox and isotope from
public/assets/vendor/. The site only loadsaos.js,bootstrap.bundle.min.js,glightbox.min.jsandisotope.pkgd.min.js(src/pages/_document.tsx); nothing references the other copies.Those unused copies were the source of every current DeepScan finding (
NULL_POINTER,INSUFFICIENT_NULL_CHECK,CONSTANT_CONDITION,UNUSED_VAR_ASSIGN,TOO_MANY_ARGS). The findings are in third-party library code and several are intentional (for examplevar h = this.element.offsetHeightforces a reflow), so removing the dead files is the fix rather than patching the libraries.Removed (14 files, ~23.7k lines):
aos/aos.cjs.js,aos/aos.esm.jsbootstrap/js/bootstrap.js,bootstrap.bundle.js,bootstrap.esm.js,bootstrap.min.js,bootstrap.esm.min.js, and their.mapfilesglightbox/js/glightbox.jsisotope-layout/isotope.pkgd.jsKept:
bootstrap.bundle.min.jsand its map, whichappeal.tsxstill needs for the collapse.Related to #269, which covers the wider template-script cleanup (relative paths, triple AOS load, unused glightbox/isotope/validate.js). This PR does not close it.
Type of change
Checklist
uat(this PR targetsuat, notmain)npx eslint .) (0 errors; 1 existing warning tracked in Tworeact-hooks/set-state-in-effectwarnings (WEB-025) #286)npx next buildsucceeds locally (also type-checks).envvalues, or user data includedTest plan
_document.tsxand_app.tsxstill exists.npx eslint .andnpx next buildpass on this branch.🤖 Generated with Claude Code