Skip to content

UAT Drone pipeline: missing compose file, Docker access with all secrets, unpinned image (WEB-014) #275

Open

Description

@LunaUrsa

Moved from REVIEW-ISSUES.md (WEB-014), found in the review of uat at a828e1e on 2026-11-07.

Files: .drone.yml:72-125

Problem.

  • Line 94 runs docker compose -f docker-compose.website-prod.yml, a file that has never been in this repository. Either the runner supplies it (undocumented) or UAT deploys fail.
  • The pipeline still has DOCKER_HOST access plus every runtime secret, the model production moved away from in 4e3af44. Anything merged into uat runs with that access.
  • appleboy/drone-discord (line 121) is unpinned; production pins it by digest.
  • REDDIT_* and DISCORD_CLIENT_ID are passed in but nothing in src/ reads them.

Fix. Confirm where the compose file comes from; move UAT to the signed-hook model; pin the image; drop unused secrets.

Notes. docker-compose.website-prod.yml lives on the UAT server; DISCORD_GUILD_ID was added to it for #258. How the Drone step's checkout reaches it is still undocumented.

Also from WEB-031 (#266). The compose file that builds the UAT image (docker-compose.website-prod.yml on the UAT server) needs build.args for the three NEXT_PUBLIC_* variables, or the ban-appeal login fix doesn't reach UAT. The production server's docker-compose.website.yml needs the same.

Same files as #277, #279, #287, #288 — Docker/Drone (.drone.yml, Dockerfile, .dockerignore, server settings). Take them together or one after another.

Activity

  1. added
    Status: AvailableReady to pick up; nobody is working on it
    Priority: MediumP2: should fix; hardening and notable improvements
    Type: MaintenanceCleanup, tooling, CI/CD, deploy, dependencies or docs
    Area: DeployDocker image, Drone pipelines and the servers (Dockerfile, .drone.yml)
    securitySecurity exposure or hardening
    on Nov 8, 2026
  2. LunaUrsa commented on Nov 8, 2026

    @LunaUrsa
    ContributorAuthor

    Two more for the UAT pipeline. The Rebuild Website UAT step uses image: docker with no tag or digest, so it runs whatever docker:latest is that day. The repo's docker-compose.website.yml isn't used by either pipeline: UAT uses the server's docker-compose.website-prod.yml, and production uses the deploy hook. It builds the development target but carries Traefik and Watchtower labels for the live domains. Either document what it is for or remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: DeployDocker image, Drone pipelines and the servers (Dockerfile, .drone.yml)Priority: MediumP2: should fix; hardening and notable improvementsStatus: AvailableReady to pick up; nobody is working on itType: MaintenanceCleanup, tooling, CI/CD, deploy, dependencies or docssecuritySecurity exposure or hardening

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions