Repository navigation
Conversation
Clears the open findings reported by the SonarQube server (1,404): - remove commented-out code (S125) - fix bug-level items: regex precedence, string sorts without a compare function, matrix switch fall-through, sample DB password in a help text - handle ignored exceptions, drop unused imports, prefer ?? / ?. / readonly, remove unnecessary assertions, and similar mechanical rules - refactor 66 over-complex functions into helpers or lookup tables (levels/profile/leaderboard cards, rpg, counting, privacy, combo, botmod, timer, reaction roles and more) with behavior unchanged - rewrite assertion-less tests; rename matrix m.test.ts to m.roletest.ts - messageModThread and idose now take an options object - exclude archived code from Sonar analysis Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| /** Plain values keep their usual text; structured values are serialized instead of printing "[object Object]". */ | ||
| function formatValue(value: unknown): string { | ||
| if (typeof value === 'object' && value !== null && !(value instanceof Date)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the 1,404 open findings on the SonarQube server for this project.
.sort()without a compare function, matrixcase 'lsd' || 'acid', and the sample DB password in anenv.validatehelp text.??/?./readonly, unnecessary assertions, nested ternaries and similar.m.test.tstom.roletest.tsso Sonar doesn't treat it as a test file.messageModThreadandidosenow take an options object (callers and tests updated).src/**/archive/**tosonar.exclusions.Things to review
||to??conversions: an empty string no longer falls back to the default (e.g. an emptyKEYCLOAK_URL). Cases where it mattered (user limit 0, trimmed-empty to null, boolean contexts) keep their old behavior.describeChannelsoutput now sorts withlocaleCompare(emoji-first names move); its test was updated./levels,/profile,/leaderboard) have no pixel-level test and deserve a visual check.tscand the tests.Verification
tsc(app, vitest and prisma configs), ESLint on changed files,git diff --check: clean.npm run tripbot:test: 2,263 passed.No Discord command definitions changed, so there is nothing to register on startup.
Tracks reworded TODO comments in #1396.
🤖 Generated with Claude Code