Repository navigation
Make /purge ephemeral by default and deploy commands on bot start - #1386
Merged
Merged
Conversation
- /purge: rename the `private` option to `ephemeral` (the code read `ephemeral`, so replies were always public) and default to a hidden reply. Fixes #1382. Requires a command redeploy. - Register slash commands on every bot start, skipping the Discord call when the definitions are unchanged since the last deploy. A failure is logged and does not stop the bot. - AGENTS.md: document the `ephemeral`-by-default option rule and the deploy-on-start behavior. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/purge: rename theprivateoption toephemeral(the code readephemeral, so the reply was always public) and make the reply hidden by default. Closes /purge reads option 'ephemeral' but the option is named 'private' #1382.npm run tripbot:deployCommandsstill always deploys and exits on failure.ephemeraloption, hidden by default" rule for commands and the deploy-on-start behavior.Notes
/purgeoption name and description changed, so this needs a command redeploy (the start-up deploy now does that on restart).entrypoint.shalready has an opt-inDEPLOY_DISCORD_COMMANDS_ON_START; with it set, Docker deploys once before start and once on start, and the second is skipped only if the hash file survived.ephemeraloption; they aren't changed here.Verification
npx vitest run src/discord/tests/utils src/discord/tests/guild/mid_guild_commands.test.ts: 620 passed, 1 expected fail.npx tsc --noEmitclean; ESLint clean on the changed files except twoobject-curly-newlineerrors on a line already inmid_guild_commands.test.ts.🤖 Generated with Claude Code