Skip to content

Venmar Station#250

Closed
DDrakov wants to merge 3 commits into
Triad-Sector:mainfrom
DDrakov:venmar-station
Closed

Venmar Station#250
DDrakov wants to merge 3 commits into
Triad-Sector:mainfrom
DDrakov:venmar-station

Conversation

@DDrakov

@DDrakov DDrakov commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

About the PR

The new CC

Why / Balance

Media

image

Requirements

  • I have read relevant guidelines/documentation to this PR found on our devwiki.
  • I have added media to this PR or it does not require an ingame showcase.
  • I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

Breaking changes

Changelog

🆑

  • add: Added new station, Venmar Station
  • remove: Removed old CC

@github-actions github-actions Bot added size/XL S: Untriaged YML No C# Doesn't contain any C# code FTL Changes to localization files Mapping and removed S: Untriaged labels Jun 22, 2026
TheRealMasterChief117
TheRealMasterChief117 reviewed Jun 22, 2026
View reviewed changes
Comment thread Resources/Prototypes/_Triad/Outpost/venmar_station.yml Outdated
icon: /Textures/_Mono/Logo/icon/icon-256x256.png # used the biggest one, looks better when downscaling than upscaling
stationSubtext: 'frontier-lobby-frontier-subtext'
stationDescription: 'frontier-lobby-frontier-description'
icon: /Textures/_Triad/Logo/tfa_icon/icon-256x256.png # used the biggest one, looks better when downscaling than upscaling

@TheRealMasterChief117 TheRealMasterChief117 Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try seeing how the 512x512 looks in the lobby

@TheRealMasterChief117 TheRealMasterChief117 Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that one looks weird and pixeled, try the smaller versions

@TheRealMasterChief117

TheRealMasterChief117 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Requires #107, #87

TheRealMasterChief117
TheRealMasterChief117 reviewed Jun 22, 2026
View reviewed changes
Comment thread Resources/Locale/en-US/_Triad/lobby/lobby.ftl Outdated
@@ -0,0 +1,8 @@
triad-lobby-triad-subtext = Main hub for many space pioneers.

@TheRealMasterChief117 TheRealMasterChief117 Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'The main hub for space pioneers, traders, mercenaries, and salvagers. Operated by the Triad Frontier Association.'

or

'In the midst of all the hardships, this station is our refuge, our spark of hope.'

@DDrakov DDrakov Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to use the first one, as the latter is for description for the POI itself

@TheRealMasterChief117

TheRealMasterChief117 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator 
Assert.That(gameMaps, Is.EquivalentTo(GameMaps.ToHashSet()))
  Expected: equivalent to < "Frontier", "NFDev" >
  But was:  < "NFDev" >
  Missing (1): < "Frontier" >

Related, tests need to accomdate venmar rather than the frontier station

@github-actions github-actions Bot added the C# label Jun 24, 2026
TheRealMasterChief117
TheRealMasterChief117 reviewed Jun 24, 2026
View reviewed changes
Comment thread Resources/Prototypes/_Triad/Outpost/venmar_station.yml Outdated
@TheRealMasterChief117

TheRealMasterChief117 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator 
  Error Message:
     Game map prototype missing from test cases.
Assert.That(gameMaps, Is.EquivalentTo(GameMaps.ToHashSet()))
  Expected: equivalent to < "Venmar", "NFDev" >
  But was:  < "Venmar" >
  Missing (1): < "NFDev" >

@TheRealMasterChief117

TheRealMasterChief117 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

In order to fix this, we'll need to make our own test map or move the mono one to the triad folders

image

@TheRealMasterChief117 TheRealMasterChief117 added the Priority: High Should be done ASAP label Jun 24, 2026
@DDrakov @TheRealMasterChief117
Update Resources/Prototypes/_Triad/Outpost/venmar_station.yml
e3b13ab 
Co-authored-by: TheRealMasterChief117 <officialtrollfacexxx@gmail.com>
@Eillyrea

Eillyrea commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Hello,

Please close this PR that's using what is nearly a hundred hours of my mapping work.

I do not grant permission for it to be used.

Good luck to whomever makes Venmar station next

@DDrakov

DDrakov commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Folloing the request of the map owner, Venmar Station PR will be closed.

@DDrakov DDrakov closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealMasterChief117 TheRealMasterChief117 TheRealMasterChief117 left review comments

Assignees

No one assigned

Labels

C# DO NOT MERGE FTL Changes to localization files Mapping No C# Doesn't contain any C# code Priority: High Should be done ASAP size/XL YML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DDrakov @TheRealMasterChief117 @Eillyrea