Kitsune Noises as a Treat#238
Draft
SquishyEmmaaaa wants to merge 18 commits into
Draft
Conversation
…arpy emotes. wheel not showing right.
…in future, and provides template. Adds chitinid, which seem to not have speechSounds Adds vulpkanin? Parenting doesnt work
…t sub-data preserving override. So no partial emote replacements for now, since it breaks the speech effects.
… indicators from DeltaV, but not the whole species DeltaV-Station/Delta-v#3175
still some bugs to squash with it, and missing the speech verbs
… mix of vulp and felinid Adds idle state to the chat indicator
…to reuse for pouts, but removes the squeak
Gives the Kitsunes some of the emotes from Hardlight, but not all
Comment out chitind
Use BorgChassis not SiliconEmotes
Comments out stuff that needs work still for later PR Adds conditions to the Harpy Emotes
github-actions
Bot
added
S: Untriaged
size/M
YML
No C#
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ports in the emotes of Kitsunes, but leaves out all the polymorph, foxfire, and psionic bits.
Adjusts speech verbs into the file under the correct namespace.
Lays groundwork for emote replacement traits using the new trait system, so that species similar to others can be implemented without needing to import the whole thing. (Have been told no kitsunes even without psionics/polymorph/other stuff, as they are too close to what we have.)
Current PR status:
-Emote implementation works why emoting by text.
-Emote wheel requires backend work to auto-adjust to allowed emotes rather than species default.
-Typing indicators seem to be overrriden even if the component is removed/added or overrriden by a trait.
Why / Balance
Media
Requirements
How to test
Breaking changes
Changelog
🆑