fix(entities): recover self-describing asset naming dropped from #258 merge#259
Merged
Conversation
…t, crypto-btc) A bare ticker like 'ccj' or 'vrt' is opaque to anyone who isn't a trader (and to the model itself) — and the name is exactly what shows in [[name]] links and the Tracked list. Asset names now prefix the instrument kind: stock-vst, stock-ccj, crypto-btc, etf-smh. Topics stay descriptive phrases. Convention is taught, not enforced (minimal schema) — updated consistently in the entity_upsert + entity_search tool descriptions, the chat workspace instruction, and the demo fixtures so they don't conflict. tsc clean both sides; golden injection test green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recovers the self-describing asset-naming convention that was authored for the entity index but dropped from PR #258's merge. The PR head lagged behind a late push, so the merge landed at the prior commit (
3898669) — the same GitHub stale-head behavior that bit #257. Master currently ships the entity index with bare tickers (vst); this restores the intended convention.assetnames are kind-prefixed:stock-vst,crypto-ccj→crypto-btc,etf-smh. A bare ticker is opaque to a non-trader (and to the model).topicnames stay descriptive phrases (ai-data-center-power).entity_upsert+entity_searchtool descriptions, the chat workspace instruction, and the demo fixtures, so they can't conflict.Mechanically this is commit
10fe5aecherry-picked onto current master — clean, since its parent (3898669) is already in master.Test plan
tsc --noEmit(Alice) +tsc -b(UI) cleanBoundary touch
None — tool descriptions + one instruction file + demo fixtures.
🤖 Generated with Claude Code