Repository navigation
Expand French localization across Diary, Foods, Goals, Statistics, and Wellness - #322
Drevilidan wants to merge 10 commits into
Conversation
|
Thanks for this, it is a big step for French users. I maintain a fork with an independent French translation, so I compared the two files (1,873 keys in common). A few suggestions, feel free to take what is useful. Proper nouns that got translated (CONTRIBUTING asks to keep them as-is)
Mistranslations that change the meaning
Buttons: French UI buttons normally use the infinitive, not the imperative with "vous": 54 keys not covered yet (mostly the Garmin Personal API section), same keys and same English source as fr.json fragment{
"settings_wellness": {
"garmin_personal": {
"enable_desc": "Importez vos pas, votre sommeil, votre fréquence cardiaque, votre VFC, votre SpO₂, votre Body Battery, votre stress et votre poids depuis Garmin Connect.",
"how_label": "Mode de connexion",
"choice_personal": "Clé API personnelle",
"choice_partner": "Programme partenaire Garmin Health",
"recommended": "Recommandé",
"choice_personal_desc": "Pour votre propre compte Garmin. La clé est gratuite et disponible sans demande d’accès. Chaque personne utilise sa propre clé.",
"choice_partner_desc": "Pour les applications approuvées dans le programme Garmin Health.",
"step_1": "Sur ordinateur, ouvrez Garmin Connect et accédez à Paramètres → Clé API personnelle.",
"step_1_link": "Ouvrir Garmin Connect",
"step_2": "Créez une clé, choisissez sa durée de validité et copiez-la. Garmin l’affiche une seule fois.",
"step_3": "Collez votre clé ici, puis cliquez sur Associer.",
"key_label": "Clé API personnelle",
"key_placeholder": "Collez votre clé Garmin",
"expiry_label": "Date d’expiration de la clé",
"expiry_desc": "Facultatif. Garmin affiche cette date à côté de la clé. NutriTrace vous prévient une semaine avant son expiration.",
"expiry_30": "30 jours",
"expiry_90": "90 jours",
"expiry_180": "180 jours",
"expiry_365": "1 an",
"region_label": "Région du compte",
"region_global": "International",
"region_cn": "Chine (garmin.cn)",
"connect": "Associer",
"connecting": "Vérification de la clé…",
"cancel": "Annuler",
"connected_toast": "Garmin est associé. Récupération des données des 30 derniers jours.",
"linked_subtext": "Clé API personnelle",
"last_synced": "Dernière synchronisation {when}",
"never_synced": "Première synchronisation en attente",
"key_expires": "Expiration de la clé",
"expires_on": "{date} ({days, plural, one {# jour restant} other {# jours restants}})",
"expires_today": "{date} (aujourd’hui)",
"expiry_unknown": "Date à renseigner",
"set_expiry": "Ajouter une date",
"edit_expiry": "Modifier la date",
"save": "Enregistrer",
"expiry_saved": "Date d’expiration enregistrée",
"expiring_soon": "Votre clé expire dans {days, plural, one {# jour} other {# jours}}. Créez une nouvelle clé dans Garmin Connect, puis choisissez Remplacer la clé.",
"expired": "La date d’expiration est passée. Si Garmin refuse la clé, créez-en une nouvelle dans Garmin Connect, puis choisissez Remplacer la clé.",
"replace_key": "Remplacer la clé",
"needs_key_label": "Nouvelle clé requise",
"needs_key": "Garmin a refusé la clé et la synchronisation s’est arrêtée. Créez une nouvelle clé dans Garmin Connect, puis collez-la ci-dessous.",
"no_data_yet": "Garmin est associé. Les mesures apparaîtront après la synchronisation de votre montre avec Garmin Connect.",
"synced_days": "{count, plural, =0 {Synchronisation terminée. Aucune nouvelle donnée Garmin.} one {Données Garmin synchronisées pour # jour.} other {Données Garmin synchronisées pour # jours.}}",
"sync_skipped": "Garmin vient de se synchroniser. Réessayez dans une minute.",
"disconnected": "Garmin est dissocié. La clé enregistrée a été supprimée.",
"partner_connected_note": "La connexion partenaire est enregistrée. Les synchronisations utilisent la clé personnelle.",
"err_bad_format": "Copiez la clé complète depuis Garmin Connect.",
"err_bad_key": "Garmin a refusé cette clé. Vérifiez qu’elle est complète, active et toujours valide.",
"err_rate_limited": "Garmin limite temporairement les demandes. Réessayez dans quelques minutes.",
"err_timeout": "Garmin n’a pas répondu à temps. Réessayez dans un instant.",
"err_unavailable": "Garmin est momentanément inaccessible. Réessayez dans un instant.",
"err_partial": "Certaines données Garmin restent à récupérer. NutriTrace réessaiera à la prochaine synchronisation.",
"err_bad_expiry": "Saisissez une date d’expiration valide."
}
}
}I can share the full side-by-side comparison (about 900 differing strings) if that helps. |
|
@Nadios-Vistos Thanks for the careful review and for comparing the translations. I’ve corrected the specific product names, mistranslations and button labels you pointed out, and added the 54 missing Garmin strings. I’m keeping the PR as a draft while reviewing the French wording. |
|
Thanks for the quick update, and for adding the Garmin strings. Here is the full comparison against your latest commit (71b76e7), as a CSV: [glisser le fichier ici] It lists the 875 strings that still differ beyond punctuation and spacing, sorted by priority, with a note in English for each flagged one:
A few caveats so you can weigh it properly:
Happy to look at the next revision. |
|
@Nadios-Vistos Thank you for the detailed comparison and for flagging where your shorter wording might lose information. I reviewed the 875 differences and have updated this draft PR with:
The second pass also caught a diagnostics message that needed to tell users to redact health data, labels that ran together because of missing spaces, and inconsistent HRV/VFC terminology. I kept the existing wording where an alternative omitted useful details. On my Android phone, Health Connect is displayed as « Santé Connect » in French. I’ve attached a visual from that screen. The i18n check and production build pass. I’m keeping the PR as a draft while the wording is reviewed. If you have time, another look at the newly translated coaching and two-step sign-in sections would be especially helpful. Thanks again. |
|
@Nadios-Vistos Following your review, I took another pass through the PR and checked the UI as well as the translation catalogue. I found that complete catalogue coverage did not translate text still written directly in components and JavaScript. I moved additional visible labels, accessibility text and contextual messages into the English and French catalogues, then connected them to the current dev code. This includes settings and Diagnostics, notifications, fasting and sync feedback, water-container names, and the offline page. I kept the French wording already established in this PR where the texts overlapped. The French catalogue now covers 3,593 of 3,593 English keys. The i18n check and production build pass locally. This key count does not mean every screen has been visually checked or that every French phrase is final: I have noticed a few awkward or imprecise translations that deserve a separate wording pass later. I’ll keep the PR as a draft while that review and the current merge conflicts with dev are addressed. Thanks again for your detailed feedback. |

Summary
devbranch.Coverage
French covers 3,593 of 3,593 English catalogue keys in this PR. The latest pass added 644 paired English/French keys and connected the corresponding UI text to the catalogues. Where it overlapped with earlier work, the French wording already established in this PR was kept.
Catalogue coverage measures key parity; it does not prove that every UI state has been visually checked or that every phrase is final. A few awkward or imprecise translations have been identified for a later wording pass.
Checks
node scripts/i18n-check.cjs— passed locally: 3,593/3,593 French keys and 3,105 code references resolved.