Fix expired FX quote retry and confirmed payout-plan compatibility - #46
Draft
TracSystems wants to merge 129 commits into
Draft
TracSystems wants to merge 129 commits into
TracSystems wants to merge 129 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stripe changes an FX quote's lock status from active to expired. A retry of an already prepared payout then rejected the same quote because its full JSON hash changed, preventing normal reconciliation. The writer now accepts that specific status transition only when the remaining quote fields still match the prepared hash, and it retains the prepared hash in settlement evidence.
The CLI also resumes a confirmed v27 payout plan during v28 settlement without trying to re-sign or replace the immutable plan. Newly created plans continue to use v28. The contract is unchanged.
Validation: focused Rust tests passed; read-only live planning succeeded against confirmed v27 and v28 plans. A writer-only canary passed the previous FX quote hash failure point.