Conversation
…ER ack Bump @rei-standard/amsg-sw 2.2.0 → 2.3.0. - 连接被浏览器强制关闭（backing store 出错 / 存储压力 / 清数据）后自愈： 挂 onclose 清缓存 + 事务级一次重开兜底，dedupe 与 queue/multipart 库同等覆盖， 并发恢复时只剔除真正失效的那个连接。无需重启 SW。 - DELIVER ack 新增可选字段 businessError：onBusinessPayload 失败时透传，ok 维持 「已收下并分发」语义（非破坏，成功时不出现该字段）。businessError 在 dedupe 记录的读写路径上一致持久化（await 后一律读最新 + firstSeenAt 身份校验），不被 重复包、通知补写或 TTL 换人擦掉或张冠李戴。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# 主要变化 新增 `client.deliver(payload, opts)` 作为推荐入口，统一协调 SSE / JSON 两路 transport 与 caller 提供的「观察通道」Promise， 返回 5 值 outcome（delivered / cancelled / timeout / send-failed / completed-unconfirmed），让接入方一眼就能正确分辨「真送达」与 「transport 失败」。 平台无关：库不绑 Service Worker / IndexedDB / Web Push / 任何 具体后端；observation 通道由 caller 注入一个普通 Promise，谁能 拿到 receipt 都能接（SW broadcast、Electron IPC、原生桥、轮询 fallback……）。 # 为什么这样设计 amsg-instant 0.9.0+ 强制 backupPush='on' 后，SSE + Web Push 双通道并发。旧 API 的两条单一信号路径都变得不可靠： sendInstant() 200 ≠ 真送达；consumeInstantStream() reject ≠ 真发送失败。naive 接入方 try/catch reject 会持续误报失败。 deliver() 把 transport 降为辅助快通道，把 receipt 作为唯一真相， 彻底消除这条陷阱。 # 旧 API 软降级 - sendInstant / consumeInstantStream 仍可用，wire-level 字节不变 - JSDoc 改标 "Low-level"，指向 deliver() - 新增可选 opts.expectsBackupPush 触发一次性 dev warning - 留两 minor 缓冲到 3.0.0，不立刻 @deprecated # 多 agent self-review + Codex 独立 review 9-angle finder（line-scan / removed-behavior / cross-file / JS pitfalls / wrapper / reuse / simplification / efficiency / altitude）抓 15 条 + Codex 二次抓 7 条，全部修：CRLF SSE 帧分隔 （含跨 chunk seam）、TextDecoder EOF flush、本地校验错误不再被 埋成 send-failed、abort 全路径 honor（pre-flight + 异步 build 后 + post-transport grace）、AbortSignal listener 卸载、 transport-only 短路 grace、application/+json 结构化后缀识别、 Content-Type 改 media-type 解析、Promise reaction 累积消除。 发布在 `next` dist-tag 给 SullyOS 端到端验证（iOS PWA + SW 双通道 + 后台杀 fetch 等 Node 单测无法仿真的场景）；55 条单测全 绿后再 graduate 到 latest 作为 2.5.0 正式版。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ettle (0.9.1-next.0) SSE 模式下让 ReadableStream.start() 完整 await LLM 调用与所有 backup / fallback push 之后才 controller.close()。响应仍在产出期间 runtime 不会施加 wall-clock 上限， 慢 LLM + iOS Safari 后台杀 SSE socket 的组合下也能把这一轮消息送达。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…0.9.1-next.1) 新增三条 SSE 生命周期回归断言： - 多 chunk + 中途 abort：每条 chunk 都通过 fallback push 投递，全部在 close 之前 - SSE 模式 waitUntil 注册数恒为 1（只剩 startDone deferred） - 慢 LLM 必须先于 controller.close() resolve 任何让 LLM 调用或 push HTTP 漂出 start() 的改动都会被拦下。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- sw: catch showNotification rejection so onNotificationSettled still runs; otherwise the dedupe record stays notificationStatePending:true forever and every backup duplicate is swallowed as 'first-delivery-pending'. - instant: replace strict `accept === 'application/json'` with acceptsJsonOnly() — tolerates `application/json; charset=utf-8` and `application/json, */*` so callers that ask for JSON actually get JSON instead of being silently routed into the SSE branch. - client: have sendInstant() set Accept: application/json. The default fetch Accept is `*/*` which would land on the SSE branch and break the subsequent res.json() with SyntaxError on the SSE bytes. - instant + server: strip <think>/<thinking>/<thought> spans from messageContent before sentence-splitting when readReasoningContent's regex fallback matched. Previously the same private chain-of-thought shipped twice — once as a ReasoningPush, once as raw markup embedded inside the ContentPush burst. Cleanup folded in: - client: drop _urlBase64ToUint8Array (byte-for-byte duplicate of shared base64UrlToBytes) and hoist a module-level TEXT_ENCODER so _encrypt + _assertPayloadSize stop allocating one per call. - client: _maybeWarnLowLevel docstring + warn message reconciled with the actual code path — the previous "Pass expectsBackupPush: false to silence" claim was a lie because the default already silences. Tests: 403/403 across client / instant / server / shared / sw. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…server 2.5.1 / sw 2.3.1 - amsg-client 2.5.0-next.0 → 2.5.0: graduate `deliver()` primitive to latest dist-tag; fold in Accept-header pin on sendInstant() and three internal cleanups. - amsg-instant 0.9.1-next.1 → 0.9.1: graduate stream-lifecycle work; add tolerant Accept parsing + <think>-tag strip from ContentPush. - amsg-server 2.5.0 → 2.5.1: mirror the <think>-tag strip so scheduled pushes do not leak chain-of-thought into the user-facing burst. - amsg-sw 2.3.0 → 2.3.1: catch showNotification rejections so the dedupe record cannot stall at notificationStatePending:true. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The in-server instant path (messageType: 'instant', create task -> process by UUID -> delete task) is now a first-class supported path again. Removed the @deprecated JSDoc and the steering toward amsg-instant; relabeled the 'legacy in-server instant' comments to neutral wording. JSDoc/README now describe both instant paths by their own characteristics: the DB-backed in-server path for long-running or zero-loss generations, and the stateless amsg-instant package for short messages on edge runtimes. Runtime behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a platform-agnostic delivery primitive deliver() in the client SDK, which coordinates foreground transport (SSE/JSON) with an out-of-band observation channel to provide reliable delivery outcomes. It also includes several critical bug fixes and improvements across the workspace: preventing private chain-of-thought reasoning tags from leaking into user-facing content, improving IndexedDB connection resilience in the Service Worker, and surfacing business-callback failures on DELIVER acks. The reviewer identified a high-severity issue in the refactored consumeInstantStream method where the options.signal is ignored, which would break the active cancellation mechanism.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
把 dev 上累积的这一轮 amsg 改动合入 main。核心是把 instant 消息的传输底座换成 SSE 默认传输 + 常驻 Web Push backup，配套 client / SW / shared 的能力补齐，外加几个 bug 修复与文档校准。
发版版本：
amsg-shared 0.2.0·amsg-client 2.5.0·amsg-instant 0.9.1·amsg-server 2.5.2·amsg-sw 2.3.1改了什么
传输与生命周期
amsg-instant：常驻 SSE backup push、可配置 keepalive；SSE 分支正确接入waitUntil生命周期；controller.close()延后到 backup push 全部 settle 之后再触发，避免提前关流丢推送client
deliver()投递原语consumeInstantStream，payload 上限可配service worker
shared
notification.silent与完整 NotificationData 字段server
messageType: 'instant'）取消弃用，恢复为一等公民：DB 路径适合长时间生成 / 零丢失，无状态场景用amsg-instantreadReasoningContent的<think>fallback 抽取重排到切句之前，避免私有 reasoning 被当 ContentPush 推给用户质量
/simplify扫出的 4 个潜在 bug 修复合并方式
main 落后 dev 16 个 commit、领先 0，快进式合并，无冲突。
🤖 Generated with Claude Code