Refactor of sound asset#1708
Open
marauder2k7 wants to merge 6 commits intoTorqueGameEngines:developmentfrom
Open
Refactor of sound asset#1708marauder2k7 wants to merge 6 commits intoTorqueGameEngines:developmentfrom
marauder2k7 wants to merge 6 commits intoTorqueGameEngines:developmentfrom
Conversation
Refactored to match image asset.
copy paste double up
Adds the backwards compatibility functions is<asset>Valid get<asset>Profile
Adds extra error output for erroneous buffer preload SndStream now correctly sets sndfile to null when it closes, Also extra error reporting around the read function SFXResource now returns a new threadsaferef each time we openstream. This should only be called on a fresh instance.
add missing inspector fields to soundasset
marauder2k7
force-pushed
the
SoundAsset-Clean-Refactor
branch
from
01da492 to
dd08600
Compare
missing declare_struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored to match image asset.